Automatically handle 404 errors when try to get image from different host

[bookimp]

Automatically handle 404 errors when try to get image from different host

[gamebeaker]

@bookimp try to update to version 0.0.0.160 it could be like this #1306 issue.

[gamebeaker]

My estimate was wrong. The problem is that the Autor embeded pictures witch get blocked with 403 error code. Example: https://freewebnovel.comenovel.com/the-rebirth-of-an-ill-fated-consort/chapter-106 image on this site with error: https://lh6.googleusercontent.com/xuxiYqUG6e6F7FurcfYQJWCAqmNYLQpD1HINXhnGhjGC6AXkZekhcTSn0Kzx-TFTuTDU3XtWGEPGh5dIyLFlaPk3d1aw0t79jlYc1iFZ
I don't know what a solution would be like.
Maybe something like a checkbox in the warning dialog "ignore future 403 warning for this session"

[gamebeaker]

more context: for each image that has this problem the 403 Warning pops up 2 times and the retry or skip dialog 1 time.

[bookimp]

@bookimp try to update to version 0.0.0.160 it could be like this #1306 issue.

Well, I've done this at least thanks. If it's a picture issue next time I start getting these I'll try clicking the button to not download them. I can add a cover myself.

[Kiradien]

This is somewhat of a global issue I've seen on other sites as well...

I've looked into this before and played with a solution, but it takes quite a few changes to the underlying code. Keep in mind, when downloading the page we are already getting information about the image that we can work with.

1. Check for failed or otherwise undisplayed image load in ImageCollector.fetchImages (failed load image has imageInfo.height == null)
2. Don't bother trying to download it.

OR

2. Add parameter to fetchImage to denote such failure.
3. Disable errors or warning on "low hope" image downloads. Code or logic change in HttpClient.FetchErrorHandler.OnResponseError - Probably a wrapOption to skip the popup.

While fundamentally it's not a difficult change to make, 15 minutes or so after these investigations, I'm not sure either route is ideal.

[dteviot]

Reopening. this is "something I should really look at doing".