Giter Site home page Giter Site logo

Comments (2)

blyxxyz avatar blyxxyz commented on June 6, 2024 1

Oh, this one's nasty. We do have a test for this feature, but test builds include the assert_cmd dependency, which includes the predicates dependency, which enables the unicode-perl feature for regex, "fixing" the problem.

Two more things went wrong:

  • Using \d instead of [0-9]
  • Given that we did use \d, disabling the default features for regex

I wonder if we could use non-test builds for the end-to-end tests. But this feature only has a unit test, so it wouldn't have helped here. And missing features should mostly cause problems at compile time, not runtime, regex is a special case.

#333 was a similar case. We should comb through our list of dependencies to look for other features we do use but don't declare.

from xh.

ducaale avatar ducaale commented on June 6, 2024

This is now fixed in xh v0.21.0

from xh.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.