allow the -O option to be specified multiple times

[dukexar]

allow the -O option to be specified multiple times

[GoogleCodeExporter]

Please ignore this. It seems -O is not a multi-value argument and only the last 
one is picked up.

Original comment by [email protected] on 15 Oct 2010 at 9:18

[GoogleCodeExporter]

Hmm.  You should be able to specify it multiple times, so if this doesn't work, 
I think it's a bug.  I'll look at it later and try to reproduce it.

Original comment by [email protected] on 15 Oct 2010 at 4:42

[GoogleCodeExporter]

Thanks for quick reply. 

I have a patch (attached). Works for both command line and environment variable 
PSSH_OPTIONS. Please comment?

Original comment by [email protected] on 16 Oct 2010 at 2:21

Attachments:

• Soham-pssh-25-1.txt

[GoogleCodeExporter]

This patch probably breaks backward compatibility with PSSH_OPTIONS env var. 
Wondering what you think. Thanks.

Original comment by [email protected] on 16 Oct 2010 at 2:27

[GoogleCodeExporter]

The environment variables definitely complicate things.  Anyway, thanks for 
posting a patch.  I'll try to look at it as soon as I can.

Original comment by [email protected] on 16 Oct 2010 at 3:11

[GoogleCodeExporter]

Sorry for the delay.  I've applied the patch with a few modifications as commit 
735985.  In particular, I left out the ability for the PSSH_OPTIONS environment 
variable to have multiple options because I'm worried that there might be some 
legitimate ssh option containing a colon character.  In general, I hope people 
will use the command-line options when they need this.  Anyway, let me know if 
you have any thoughts or if you see any problems.  I plan on releasing a 
version 2.2 sometime this week that will include this fix.  Thanks for your 
help.

Original comment by [email protected] on 9 Jan 2011 at 6:15

• Changed state: Started

[GoogleCodeExporter]

Original comment by [email protected] on 9 Jan 2011 at 6:19

• Changed title: allow the -O option to be specified multiple times

[GoogleCodeExporter]

I'm going to mark this as fixed for now.  Please reopen if you see any problems 
with the fix.  Thanks.

Original comment by [email protected] on 10 Jan 2011 at 2:37

• Changed state: Fixed