Giter Site home page Giter Site logo

Comments (2)

hollowsxd avatar hollowsxd commented on July 24, 2024

For feature 1, I think both have the same item id? correct me if i'm wrong (I am wrong) and for feature 2, placing the percentage next to item set same would clutter it IMO but it can be done

EDIT: It appears that both item have different id, eg: rod of ages-3027 while quick charge roa-3029

from championify.

DarkRobotix avatar DarkRobotix commented on July 24, 2024

Yep, the item completely disappears from the build because they have different IDs. There are more items that fall into this category too like Wooglets on Twisted Treeline, which is DCap+Zhonyas, so if the build had one of those it could also be swapped to Wooglets instead.

But the reverse of this idea could be useful too. For example, having the Special Poro Snax from Poro King in every build. But since they only show up in the shop in that specific mode, They won't clump up the shop for games in other modes. I don't know about Ornn upgrades as they sometimes show up in custom item sets and others not (and sometimes 2 times) but could be permanently 'forced' in there as well. Same goes for GP and Viktor Upgrades and some other champion/game mode specific items like buildings in Nexus Siege etc

This is solely for the convenience of not having to switch back and forth to the regular shop and your item set to purchase these items. Not sure how much more space/resources this would take so it could be a tick box so people who don't want this or their potato machines can't handle it can opt out for this function.

maybe feature 2 could be a tick box too so only people who want the stat will see it

from championify.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.