Comments (4)
There is something in this PR, #951, that introduced this change in behavior. Using my nifty new tool, git bisect
that I picked up from Django, it's definitely pinpointed to that PR as the introduction in change in behavior. I'm open to any suggestions!
from dynaconf.
There appears to be a similarly related timing bug, I can't use a lazily evaluated value inside of @pytest.mark.parametrize
@pytest.mark.parametrize(
("expected_url"),
[settings.LOGIN_URL)],
)
def test_url(expected_url):
assert expected_url == "/admin/login/"
from dynaconf.
Hey, thanks for the investigation and the reproduction, I'll try to have a look into this.
from dynaconf.
I have a theory.
Just some context, the #951 PR adds a post-load hook function is used there because we can't import reverse_lazy on the top_module in settings.py
. But here is what I think is happening:
- instantiate DjangoDynaconf: register hook that loads @reverse_lazy
- execute_loader: here we load default, user settings etc
- When LOGIN_URL is loaded, its interpreted as a string, because the @reverse_lazy was not added yet (the hook is a "post" hook, its executed after loading).
- post-hook is called, which then effectively registers the @reverse_lazy function, but it doesn't take effect unless we do load the setting again.
Then, if somehow we make dynaconf re-execute the loaders, the @reverse_lazy will take effect because it will be present on loading time. The with_env
context calls the settings reloading, but other reloads, such as using settings.get("LOGIN_URL", fresh=True)
has the same effect (it also "fixes" the problem).
My first thought for approaching this is implementing a pre-hook and calling it before the loaders execution.
from dynaconf.
Related Issues (20)
- [bug] Environment Variable Overrides Not Working with Nested .toml Values HOT 1
- [bug] Dynaconf.load_file() no error on missing file(s)
- Documentation used to be clear on purpose of global, and the default environment HOT 2
- Multiple cast validators get discarded
- Broken link to source code in docs HOT 1
- Standard docstrings style for the codebase HOT 3
- Validator default string parsed to number HOT 3
- [bug] Validation on Dynaconf instantiation not working HOT 1
- Validation doc section "On instantiation" improvement HOT 2
- [CI] New release process HOT 2
- [RFC] Add `as_dict` alias to `to_dict` for `DynaBox` for consistency between `LazySettings` and `DynaBox` objs HOT 1
- [CI] Update codecov configuration file
- [RFC] Add FORCE_SETTINGS_FILES to LazySettings.configure() for pytest
- [RFC] Use profile link of a contributor in the CHANGELOG
- [RFC] Provide workaround for auto-complete w/ Schema HOT 2
- [bug] Loading config values failing in Python 3.11 while it works in Python 3.10 HOT 1
- [bug] fresh_vars items are assignable HOT 2
- k8s file-mounted secrets HOT 1
- [RFC] Add option to perform a self token renew when using vault
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from dynaconf.