Giter Site home page Giter Site logo

Comments (7)

Narrat avatar Narrat commented on June 11, 2024 1

I don't know about that and therefore this is no clarification whatsoever. But maybe it provides some intel?
I noticed this note in the README of kdf dir:

Base64 vs hexencode
-------------------

While base64 is easier to use (shell command, more compact), pbkdf2 use hex
in its specifications.
This could be solved with an option (-x for hex, defaults to base64)

And I interpret it that is was there to be more following the spec.
Thinking about the age of gtomb and the argument, that pbkdf is kinda dated, one may look into adopting argon2 if there is a revisit of gtomb?

Edit: To clarify further: Point being that argon2i is seen as superior and the chance is high it is available from the distribution repos or even already installed.

from tomb.

jaromil avatar jaromil commented on June 11, 2024 1

Thanks for checking that. I didn't wanted to state something just relying in what I remember, but can confirm that AFAIK was never used.

from tomb.

jaromil avatar jaromil commented on June 11, 2024 1

beware the addition of argon2 affects also the core tomb script, because it requires a new option in the header (first line of key file) stating argon2 and parameters.

from tomb.

jaromil avatar jaromil commented on June 11, 2024 1

I forgot that I did that 😅 perhaps because I am not yet using it in my workflow, just planning to 😅😅

from tomb.

nerun avatar nerun commented on June 11, 2024

Reopened it.

I agree with you. Argon2i is more up to date.

But is tomb-kdb-hexencode still used in the main code? Or it just use Base64 as default? My PR #478 removed tomb-kdb-hexencode check to use KDF to create a key with gtomb.

Exploring the extras/kdf-keys and tomb (current and old versions) seems that tomb-kdb-hexencode was NEVER used. Apparently pbkdf2 has it's own hex encode source-code inside tomb-kdf-pbkdf2*.

from tomb.

nerun avatar nerun commented on June 11, 2024

Thank you @jaromil and @Narrat for all the help. I will update extras/gtomb to include argon2 as an alternative to pbkdf2.

from tomb.

Narrat avatar Narrat commented on June 11, 2024

beware the addition of argon2 affects also the core tomb script, because it requires a new option in the header (first line of key file) stating argon2 and parameters.

Shouldn't this be covered already? As tomb got argon2 support with #432 ?

from tomb.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.