Refactor: k8s-agent private-key init: generate

[dyrector-io]

Refactor: k8s-agent private-key init: generate

[minhoryang]

This is my first attempt of using a golang on production. so my question would be quite silly for maintainers.

I'm getting a circular import error between agent/pkg/crane/config/secret.go and agent/pkg/crane/k8s/secret.go during

• Create new type in a similar way for achieving similar effects using secrets into crane ConfigFromSecret pkg/crane/config/secret.go
• The new type setter in crane expects a string (namespace), from env variable: NAMESPACE - also new.
• In the setter
  • If namespace not provided, attempt to use the dyrectorio namespace
  • GetSecretClient function can be reused from k8s package - expose it
  • Load secret value

What about moving all ConfigFromSecret related codes to agent/cmd/crane/secret.go?

[nandor-magyar]

There is nothing silly about asking questions, the most efficient way would be if you could open a draft PR with the changes you have already.
Moving into the cmd directory is not really preferred if it used elsewhere in under pkg, but isolating the common part is the right approach. 👍

[minhoryang]

Hello @nandor-magyar , I'm interested in this issue.

During the initial investigation of below todo, I have no idea that how to save the output from initContainer's stdout to k8s opaque secret in yaml form.

4. Save the output to a k8s opaque secret

Do I need to store it directly through the Kube API? or Call kubectl create on Makefile?

[minhoryang]

The new type setter in crane expects a string (namespace), from env variable: NAMESPACE - also new.

Oh, maybe I need to implement it as first way ("directly through the Kube API" in crane itself.)

[nandor-magyar]

Correct. You can use crane's functions, though I would assume you won't need much of the code, only a secret client that is mentioned in the issue.