Nextcloud 14 - drop of deprecated APIs

[e-alfred]

Nextcloud 14 - drop of deprecated APIs

[e-alfred]

Okay, the app is now fixed with 25407d0 and c4edc54 so it will work with Nextcloud 14. I will leave this open anyway because there surely will be some more changes over time.

[MorrisJobke]

Please also have a look at nextcloud/server#7827 for other dropped methods or use the app:code-check to highlight deprecated methods in the current code.

[e-alfred]

Thanks for the info @MorrisJobke!

Is there a new PHPDoc for Nextcloud or is it still located at https://doc.owncloud.org/api/?

[MorrisJobke]

Is there a new PHPDoc for Nextcloud or is it still located at https://doc.owncloud.org/api/?

Best is to have a look at the code directly. Just look into the PR with the deleted code - for example: https://github.com/nextcloud/server/pull/7840/files#diff-152326d1a90608424fb90b9a3b29030cL55

[MorrisJobke]

Could you replace the OC_API constants in routes.php with the ones from OCP\API?

ocdownloader/appinfo/routes.php

Line 73 in 0767242

\OC_API::USER_AUTH

ocdownloader/appinfo/routes.php

Line 83 in 0767242

\OC_API::USER_AUTH

ocdownloader/appinfo/routes.php

Line 93 in 0767242

\OC_API::USER_AUTH

Or maybe migrate all three methods to the AppFramework?

[MorrisJobke]

See https://github.com/nextcloud/server/blob/ba87db3fccb40aa58d84d12932424c83a4db411f/lib/public/API.php#L49

[MorrisJobke]

See nextcloud/server#8788 for the removal of the private namespace constant.

[e-alfred]

I fixed the deprecated constants with 217ae7c#diff-0e033fd8797499a87a6bf2ffccef5c3c. I am keeping a move to the AppFramework on my TODO list.

Thanks for the awesome community support!

[MorrisJobke]

Thanks for the awesome community support!

You are welcome :) Would be sad if it is a that easy fix that could avoid problems in the future ;)

[e-alfred]

Yes, it is just that I can't always keep track of all important/serious changes, so it helps quite a bit.

[MorrisJobke]

Just want to ping you, @e-alfred 😉

[e-alfred]

This should be fixed now.

[e-alfred]

I have to reopen this because the OCP\API calls seem to be broken by a recent change making the API unusable. Maybe @MorrisJobke you can help me with that?

I am getting the following error message in my log:

{"reqId":"nwxEpX2tXmmmZvAnMPo4","level":3,"time":"2019-04-15T13:14:33+00:00","remoteAddr":"10.0.2.2","user":"--","app":"PHP","method":"POST","url":"\/ocs\/v1.php\/apps\/ocdownloader\/api\/version?format=json","message":"Error: Call to undefined method Exception::getResult() at \/var\/www\/nextcloud\/ocs\/v1.php#71","userAgent":"Mozilla\/5.0 (X11; Linux x86_64) AppleWebKit\/537.36 (KHTML, like Gecko) Chrome\/73.0.3683.88 Safari\/537.36 Vivaldi\/2.4.1488.36","version":"16.0.0.5"}

Testing a change to OC_API I get the following message:

{"reqId":"cwsXeNWU1uVB6stlKR4A","level":3,"time":"2019-04-15T13:16:36+00:00","remoteAddr":"10.0.2.2","user":"--","app":"no app in context","method":"POST","url":"\/ocs\/v1.php\/apps\/ocdownloader\/api\/version?format=json","message":{"Exception":"Symfony\\Component\\Routing\\Exception\\RouteNotFoundException","Message":"Unable to generate a URL for the named route \"theming.Theming.getJavascript\" as such route does not exist.","Code":0,"Trace":[{"file":"\/var\/www\/nextcloud\/lib\/private\/Route\/Router.php","line":337,"function":"generate","class":"Symfony\\Component\\Routing\\Generator\\UrlGenerator","type":"->","args":["theming.Theming.getJavascript",{"v":"0"},1]},{"file":"\/var\/www\/nextcloud\/lib\/private\/URLGenerator.php","line":79,"function":"generate","class":"OC\\Route\\Router","type":"->","args":["theming.Theming.getJavascript",{"v":"0"}]},{"file":"\/var\/www\/nextcloud\/apps\/theming\/appinfo\/app.php","line":48,"function":"linkToRoute","class":"OC\\URLGenerator","type":"->","args":["theming.Theming.getJavascript",{"v":"0"}]},{"file":"\/var\/www\/nextcloud\/lib\/private\/legacy\/app.php","line":261,"args":["\/var\/www\/nextcloud\/apps\/theming\/appinfo\/app.php"],"function":"require_once"},{"file":"\/var\/www\/nextcloud\/lib\/private\/legacy\/app.php","line":154,"function":"requireAppFile","class":"OC_App","type":"::","args":[{"__class__":"OCP\\AppFramework\\App"}]},{"file":"\/var\/www\/nextcloud\/lib\/private\/legacy\/app.php","line":127,"function":"loadApp","class":"OC_App","type":"::","args":["theming"]},{"file":"\/var\/www\/nextcloud\/ocs\/v1.php","line":56,"function":"loadApps","class":"OC_App","type":"::","args":[]}],"File":"\/var\/www\/nextcloud\/3rdparty\/symfony\/routing\/Generator\/UrlGenerator.php","Line":130,"CustomMessage":"--"},"userAgent":"Mozilla\/5.0 (X11; Linux x86_64) AppleWebKit\/537.36 (KHTML, like Gecko) Chrome\/73.0.3683.88 Safari\/537.36 Vivaldi\/2.4.1488.36","version":"16.0.0.5"}

[MorrisJobke]

I am getting the following error message in my log:

Do you mind to show the code that is causing this?

[e-alfred]

It is actually this code you also reffered to here #58 (comment):

ocdownloader/appinfo/routes.php

Line 66 in 0987de5

\OCP\API::register(

and

ocdownloader/controller/lib/api.php

Line 1 in 0987de5

<?php

.

[MorrisJobke]

The OCS API could be used with normal controllers by now. Registration is done in this way:

https://github.com/nextcloud/server/blob/bb58d12bcaf991530be1c526d5de78e473936734/apps/updatenotification/appinfo/routes.php#L29-L31

and the controller is a normal controller returning DataResponse's.

[e-alfred]

Fixed by 49dd4af.