Comments (1)
Hi @tch1bo
Thanks for the reports. I know there are some holes, thanks for pointing them
out and suggesting flask.escape(resp)
. That suggestion was much
appreciated!
And just to be clear on the points for anyone happening to stumble onto this.
The XSS and the SQL injections vulnerabilities (#86) are known and stated in the
documentation - https://earthgecko-skyline.readthedocs.io/en/latest/webapp.html?highlight=injection#production-infrastructure
These vulnerabilities are somewhat offset by the implementation of a number of
migitations such as:
- The implementation of basic http auth and a SSL terminated frontend
- Forcing
@requires_auth
on all the webapp.py endpoints - Testing the validilty each parameter in the requests
These are not excuses, they are mitigations for known lacks of knowledge in
certain aspects.
In your example, webapp.py will respond with Bad request 400 as fp_id as a
Python type is not instanceof int.
Due to this lack of knowledge on a number of fronts in terms of sorting out XSS
and SQL injection, all request parameter values are tested and further to this
the user of Skyline is somewhat now forced into setting it up with multiple
layers of defence in terms of it's actually deployment. But you cannot always
rely on users to read the documentation and do it properly, so the default
setup makes it hard to configure it open, by default it is configured hard.
Although it would be much better to fix it as well, I do agree :)
I shall draft a release to address the XSS and mull over the SQL #86 as well.
Thanks for the report. I guess we are a ways off deepcode.ai being able to
analyse code, configs and docs in a multivariate manner good enough to interpret
stuff that has an average cyclonic complexity score of about F AND make
sense of it all :) But I do like it :)
from skyline.
Related Issues (20)
- Example HOT 1
- Using prometheus or netdata with skyline HOT 2
- Change ionosphere_enabled if all features profiles are disabled HOT 1
- How Does Skyline Handle Seasonal Data. HOT 6
- AttributeError: 'list' object has no attribute 'metric' - Panorama not working HOT 3
- Dependency vulnerability - py - CVE-2020-29651 HOT 1
- PYTHON GOVNO HOT 1
- Python не язык.
- Why piton govno?
- [Q] How do I make a metrics appear and select it in the "metric name" section? HOT 3
- [Q] The "horizon.test.pickle" test is getting an error. HOT 1
- Luminosity's possible process preventing condition HOT 1
- Redis exception in horizon HOT 8
- ValueError: can't have unbuffered text I/O HOT 1
- v3.0.0 HOT 1
- v3.0.0 misspelt replace file HOT 1
- webapp sometimes fails to start in v3.0.0 HOT 1
- feature section HOT 1
- Installation link broken HOT 1
- Is it possible to use Skyline for performance test analisys HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from skyline.