`data_codebook`, add commas for thousands?

[etiennebacher]

`data_codebook`, add commas for thousands?

[strengejacke]

datawizard::data_codebook(openintro::military)
#> openintro::military (1,414,593 rows and 6 variables, 6 shown)
#> 
#> ID | Name   | Type        | Missings |          Values |         N
#> ---+--------+-------------+----------+-----------------+----------
#> 1  | grade  | categorical | 0 (0.0%) |        enlisted | 1,183,889
#>    |        |             |          |         officer |   211,525
#>    |        |             |          | warrant officer |    19,179
#> ---+--------+-------------+----------+-----------------+----------
#> 2  | branch | categorical | 0 (0.0%) |       air force |   331,486
#>    |        |             |          |            army |   555,849
#>    |        |             |          |    marine corps |   202,966
#>    |        |             |          |            navy |   324,292
#> ---+--------+-------------+----------+-----------------+----------
#> 3  | gender | categorical | 0 (0.0%) |          female |   202,718
#>    |        |             |          |            male | 1,211,875
#> ---+--------+-------------+----------+-----------------+----------
#> 4  | race   | categorical | 0 (0.0%) |         ami/aln |    23,984
#>    |        |             |          |           asian |    51,735
#>    |        |             |          |           black |   241,133
#>    |        |             |          |           multi |    26,054
#>    |        |             |          |             p/i |     8,703
#>    |        |             |          |             unk |    71,269
#>    |        |             |          |           white |   991,715
#> ---+--------+-------------+----------+-----------------+----------
#> 5  | hisp   | logical     | 0 (0.0%) |           FALSE | 1,265,480
#>    |        |             |          |            TRUE |   149,113
#> ---+--------+-------------+----------+-----------------+----------
#> 6  | rank   | integer     | 0 (0.0%) |         [1, 11] | 1,414,593
#> ------------------------------------------------------------------

^{Created on 2022-11-07 with reprex v2.0.2}

[strengejacke]

Also, for tests, I think it would be easier to use snapshots in this case because modifying hardcoded outputs one by one will be painful if there's a small change in design later.

Yeah, but I cannot get snapshot tests working properly. Once the design is stable, there's hopefully less change ;-)