homebridge-zp crashes Homebridge

[cakefornoreason]

homebridge-zp crashes Homebridge

[ebaauw]

They changed the AlarmClock interface in sonos, the package I use to interact with the Sonos players. Maybe I missed one. What version of homebridge-zp are you on? Could you check the version of sonos as well through npm -g list --depth=1?

[cakefornoreason]

I'm using the newest (just a few hours old) version of homebridge-zp, and the sonos version listed in my setup is 0.22.1

[ebaauw]

Ah, I can reproduce the error. You don't have any alarms defined on your Sonos, do you? As a workaround you could just define two dummy alarms (just leave it disabled), and the error will go away. I'll check what's causing this and come up with a fix.

Unfortunately, the error occurs, even when alarms is not set in config.json.

[cakefornoreason]

Hmm... the fix of adding an alarm and disabling it doesn't seem to fix it for me. I'll keep checking, but alternately, I've been using a config.json that just disables the platform and that works fine, of course.

If there's anything else I can try out for you, I'd be glad to help out. Thanks!

[ebaauw]

Hmm... the fix of adding an alarm and disabling it doesn't seem to fix it for me

No it doesn't. That's why I said: "workaround".

I did find the cause: bencevans/node-sonos#211.

[cakefornoreason]

Sorry, didn't mean to call it a "fix." What I mean is that I still get the crash even with an alarm present, so at least for me, adding an alarm doesn't appear to work as a workaround, but again, it could be some other part of my specific config. Fortunately, the Sonos/HomeKit integration isn't critical for me. Good catch on finding the source though! I'll stay tuned :)

[ebaauw]

v0.2.16 will only crash when "alarms" is set in config.json and there's less than two alarms on Sonos. I've issued a PR to node-sonos (bencevans/node-sonos#212) to fix that, but we'll have wait and see if they accept it.

[ebaauw]

Fortunately, the Sonos/HomeKit integration isn't critical for me.

Yeah, less critical to me as well. Because of that, I've spent far less effort on homebridge-zp to make it bullet proof like homebridge-hue. Every advantage has its disadvantage...

[ebaauw]

OK, the fix is included in [email protected]. If you re-install homebridge-zp, npm should update sonos:

$ npm -g list --depth=1
/usr/local/lib
├─┬ [email protected]
│ ├── [email protected]
│ ├── [email protected]
│ ├── [email protected]
│ ├── [email protected]
│ ├── [email protected]
│ └── [email protected]
├─┬ [email protected]
│ ├── [email protected]
│ ├── [email protected]
│ ├── [email protected]
│ └── [email protected]
...
$ sudo npm -g i homebridge-zp
Password:
+ [email protected]
updated 2 packages in 2.753s
$ npm -g list --depth=1
/usr/local/lib
├─┬ [email protected]
│ ├── [email protected]
│ ├── [email protected]
│ ├── [email protected]
│ ├── [email protected]
│ ├── [email protected]
│ └── [email protected]
├─┬ [email protected]
│ ├── [email protected]
│ ├── [email protected]
│ ├── [email protected]
│ └── [email protected]
...

[cakefornoreason]

Updated version works like a charm. Thanks for looking into this!