Giter Site home page Giter Site logo

Bounciness about nmessenger HOT 4 CLOSED

ebay avatar ebay commented on June 18, 2024
Bounciness

from nmessenger.

Comments (4)

zdnk avatar zdnk commented on June 18, 2024

I think NMessenger conversation view is implemented via AS/UITableView so I dont think so. However it should not be too hard to reimplement the whole thing in AS/UICollectionView.

from nmessenger.

jyounus avatar jyounus commented on June 18, 2024

Good point. I've just asked the question over at the ASDK repo. For anyone that's interested in the answer, hopefully you'll be able to find it here (whenever someone replies):

facebookarchive/AsyncDisplayKit#2116

Now a different question for the authors/maintainers of this repo, would you consider adding this to your roadmap or would this be rather something you'd want for someone else to create a PR for?

from nmessenger.

atainter avatar atainter commented on June 18, 2024

I wouldn't be opposed to adding it. However, I believe most of our layouts rely on the width of the astableview component through layoutspecsthatfit. Changing NMessenger to a collectionview would probably affect most of the messenger components. If our test code coverage was higher, I would feel more comfortable changing it.

While improving code coverage is a near term goal, I'm not sure when I'll get around to switching the tableview. Once I've improved code coverage and changed the tableview to a collectionview, I'd prefer someone else would submit a PR to integrate UIDynamics since I have no experience with it.

from nmessenger.

jyounus avatar jyounus commented on June 18, 2024

Fair enough, makes sense. Thanks! If I ever do get the chance to try it out, I'll make sure to submit a PR.

from nmessenger.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.