Comments (4)
I think NMessenger conversation view is implemented via AS/UITableView so I dont think so. However it should not be too hard to reimplement the whole thing in AS/UICollectionView.
from nmessenger.
Good point. I've just asked the question over at the ASDK repo. For anyone that's interested in the answer, hopefully you'll be able to find it here (whenever someone replies):
facebookarchive/AsyncDisplayKit#2116
Now a different question for the authors/maintainers of this repo, would you consider adding this to your roadmap or would this be rather something you'd want for someone else to create a PR for?
from nmessenger.
I wouldn't be opposed to adding it. However, I believe most of our layouts rely on the width of the astableview component through layoutspecsthatfit. Changing NMessenger to a collectionview would probably affect most of the messenger components. If our test code coverage was higher, I would feel more comfortable changing it.
While improving code coverage is a near term goal, I'm not sure when I'll get around to switching the tableview. Once I've improved code coverage and changed the tableview to a collectionview, I'd prefer someone else would submit a PR to integrate UIDynamics since I have no experience with it.
from nmessenger.
Fair enough, makes sense. Thanks! If I ever do get the chance to try it out, I'll make sure to submit a PR.
from nmessenger.
Related Issues (20)
- NMessenger With SwiftR HOT 1
- Text Count
- Contents are not showing properly and I want to set the border for message view. HOT 5
- Adding image from Gallery hides the my custom view and chat.
- Crash when attempt to send collectionView. HOT 2
- Next release? HOT 1
- Message full width of screen HOT 5
- emojis are not showing properly
- Scroll to last Item Bug HOT 5
- Collection view with custom views not working HOT 2
- Head Prefetching Batch Fetch Content HOT 1
- Need to show message cell from bottom to top for chat messages. HOT 1
- How to show loading indicator at top & change scroll direction from bottom to top for load more? HOT 1
- Asyncdisplaykit not updated HOT 3
- AddToGroup breaks with Texture 2.4.0 HOT 1
- Update cell data HOT 3
- Chat bubble is shown only partially HOT 1
- how can i make a multiple select system?
- Updated swfit 4.2 Seems Like Texture is requesting for AssetsLibrary, update pods
- Data race crashes application
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from nmessenger.