Giter Site home page Giter Site logo

Comments (8)

atainter avatar atainter commented on September 27, 2024 1

I'm writing a functional test for orientation so that we can catch it next time. @DavidSchechter can you look into the inputbar issue?

from nmessenger.

atainter avatar atainter commented on September 27, 2024 1

I've already fixed it in my PR (#46). Waiting for @DavidSchechter to merge it.

from nmessenger.

atainter avatar atainter commented on September 27, 2024

@JustinM1 I just did some testing on my end. It looks like NMessengerViewController is Not rotating based on orientation for me. Did you override shouldAutorotate?

screen shot 2016-09-15 at 11 47 27 am

from nmessenger.

atainter avatar atainter commented on September 27, 2024

Update: did some more testing. It looks like app is launched in a landscape orientation, NMessenger starts and gets locked in the landscape mode.

from nmessenger.

JustinM1 avatar JustinM1 commented on September 27, 2024

Yea I didn't adjust anything relating to rotation and it was actually rotating before I even started looking at the source code. I've only been coding for 8months or else I'd try to be of more help in solving the problem. If there is anything I can do just let me know.

from nmessenger.

atainter avatar atainter commented on September 27, 2024

PR #46 merged

from nmessenger.

DavidSchechter avatar DavidSchechter commented on September 27, 2024

@JustinM1 regarding the keyboard issue:
I can't reproduce your issue.
What device is this happing on?
Are you imbedding NMessenger inside anything?
Can you make a demo project to show the problem?

from nmessenger.

JustinM1 avatar JustinM1 commented on September 27, 2024

@DavidSchechter sorry for delay. I was looking into the issue some more and I believe what the issue was is that I also had IQKeyboardManager dependency in project. After removing it the issue was resolved. It seems that was causing the issue with the dismissing of the keyboard in certain situations. Thanks for following up.

from nmessenger.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.