Giter Site home page Giter Site logo

Open keyboard animation about nmessenger HOT 5 CLOSED

ebay avatar ebay commented on June 26, 2024
Open keyboard animation

from nmessenger.

Comments (5)

DavidSchechter avatar DavidSchechter commented on June 26, 2024

@Sundin I see the issue you are talking about.
I don't know currently how to fix it. The tableview size is being changed by the iOS when I update a constraint on the input view.
It could be a bug in iOS.
If we move the scrolling to the commotion block of the animation than it goes away, so it could be cause both animation are happing at the same time, and the scrolling is showing the old height while it's updating.
If more people open bugs like this ones, we will look more into it, as this is only visible when recording the screen in slow motion.

A potential fix would be to change this:

UIView.animate(withDuration: duration,
                                       delay: TimeInterval(0),
                                       options: animationCurve,
                                       animations: { self.view.layoutIfNeeded()
                                        if self.isKeyboardIsShown {
                                            self.messengerView.scrollToLastMessage(true)
                                        }
                },
                                       completion: nil)
        }

To have the option of either scrolling during the animation or in the completion block, depending on a flag set during init.

from nmessenger.

Sundin avatar Sundin commented on June 26, 2024

Hello and thanks for your quick reply!

While this effect is more significant in slow motion, it is still present as a disturbing flicker while running the app in real-time (see the gif below).

ezgif com-resize

from nmessenger.

arneson avatar arneson commented on June 26, 2024

I am also having this issue, does not look very good when the last messages flicker.
Do you have any idea what could be the issue? I tried looking at it, it feels like it's just an animation missing somewhere? Maybe animate the change of the table view height? @DavidSchechter 🤔

from nmessenger.

DavidSchechter avatar DavidSchechter commented on June 26, 2024

I have a fix for this issue. However, I cannot merge it because of issues with #42. Once those are resolved I will merged a fix for this issue.

from nmessenger.

DavidSchechter avatar DavidSchechter commented on June 26, 2024

Fixed in #53

from nmessenger.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.