Giter Site home page Giter Site logo

Use Legacy Swift Language Version about nmessenger HOT 3 CLOSED

ebay avatar ebay commented on September 27, 2024
Use Legacy Swift Language Version

from nmessenger.

Comments (3)

loretoparisi avatar loretoparisi commented on September 27, 2024

[UPDATE]
If I add both to MessageGroups target and Pods/NMessenger the flag to NO, I get some few errors, that Xcode helped me to resolve one by one in the editor.

from nmessenger.

DavidSchechter avatar DavidSchechter commented on September 27, 2024

Please look at this issue CocoaPods/CocoaPods#5864
This is a cocoapods issue and not a nmessenger issue

from nmessenger.

loretoparisi avatar loretoparisi commented on September 27, 2024

@DavidSchechter yes thanks I have solved it, "faking" the requested Swift 3.0 update by Xcode, that didn't change anything actually, setting the Use Legacy Swift Language Version to NO explicitly, and solving by hand some errors in the ViewController.swift

This is the diff requested by Xcode8

$ git diff ViewController.swift 
diff --git a/examples/MessageGroups/MessageGroups/ViewController.swift b/examples/MessageGroups/MessageGroups/ViewController.swift
index 5674d41..d7fdd5e 100644
--- a/examples/MessageGroups/MessageGroups/ViewController.swift
+++ b/examples/MessageGroups/MessageGroups/ViewController.swift
@@ -24,14 +24,14 @@ class ViewController: NMessengerViewController {
     override func viewDidLoad() {
         super.viewDidLoad()

-        self.senderSegmentedControl.frame = CGRect(x: self.segmentedControlPadding, y: UIApplication.sharedApplication().statusBarFrame.height, width: self.view.frame.width-2*self.segmentedControlPadding, height: self.segmentedControlHeight)
+        self.senderSegmentedControl.frame = CGRect(x: self.segmentedControlPadding, y: UIApplication.shared.statusBarFrame.height, width: self.view.frame.width-2*self.segmentedControlPadding, height: self.segmentedControlHeight)
         self.senderSegmentedControl.selectedSegmentIndex = 0
         self.navigationController?.view.addSubview(self.senderSegmentedControl)

         self.automaticallyAdjustsScrollViewInsets = false
     }

-    override func sendText(text: String, isIncomingMessage: Bool) -> GeneralMessengerCell {
+    override func sendText(_ text: String, isIncomingMessage: Bool) -> GeneralMessengerCell {

         //create a new text message
         let textContent = TextContentNode(textMessageString: text, currentViewController: self, bubbleConfiguration: self.sharedBubbleConfiguration)
@@ -41,9 +41,9 @@ class ViewController: NMessengerViewController {

         //add message to correct group
         if (self.senderSegmentedControl.selectedSegmentIndex == 0) { //incoming
-            self.postText(newMessage, isIncomingMessage: true)
+            self.postText(message: newMessage, isIncomingMessage: true)
         } else { //outgoing
-            self.postText(newMessage, isIncomingMessage: false)
+            self.postText(message: newMessage, isIncomingMessage: false)
         }

         return newMessage
@@ -66,7 +66,7 @@ class ViewController: NMessengerViewController {

             self.lastMessageGroup!.isIncomingMessage = isIncomingMessage
             self.messengerView.addMessageToMessageGroup(message, messageGroup: self.lastMessageGroup!, scrollsToLastMessage: false)
-            self.messengerView.addMessage(self.lastMessageGroup!, scrollsToMessage: true, withAnimation: isIncomingMessage ? .Left : .Right)
+            self.messengerView.addMessage(self.lastMessageGroup!, scrollsToMessage: true, withAnimation: isIncomingMessage ? .left : .right)

         } else {
             self.messengerView.addMessageToMessageGroup(message, messageGroup: self.lastMessageGroup!, scrollsToLastMessage: true)
@@ -90,7 +90,7 @@ class ViewController: NMessengerViewController {
      */
     private func createAvatar()->ASImageNode {
         let avatar = ASImageNode()
-        avatar.backgroundColor = UIColor.lightGrayColor()
+        avatar.backgroundColor = UIColor.lightGray
         avatar.preferredFrameSize = CGSize(width: 20, height: 20)
         avatar.layer.cornerRadius = 10
         return avatar

from nmessenger.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.