Giter Site home page Giter Site logo

Comments (15)

srobb1 avatar srobb1 commented on June 11, 2024 1

Hi Everyone,

We use:

from ols4.

udp avatar udp commented on June 11, 2024

@matentzn I don't suppose you know if anyone is using it?

from ols4.

matentzn avatar matentzn commented on June 11, 2024

@srobb1? @shawntanzk on the new CL site (I don't think so, just covering bases)? I
Can't think of anyone else top of my head!

from ols4.

shawntanzk avatar shawntanzk commented on June 11, 2024

We are only using the autocomplete widget for CL site, which I assume doesn't use jstree endpoint?

from ols4.

henrietteharmse avatar henrietteharmse commented on June 11, 2024

@shawntanzk Correct. This does not affect the autocomplete widget. Good point on the widgets though - we need to remember the widgets and the autocomplete widget is likely to be effected by OLS4.

@matentzn Can you please flag who is potentially using the autocomplete and tree control widgets?

@udp Let us not implement the jstree endpoint for now at least until we get undeniable evidence to the contrary. It will really make our lives easier if we do not have to implement it.

from ols4.

udp avatar udp commented on June 11, 2024

Thanks all. So we need to decide whether to:

  1. Reimplement the OLS3 graph and jstree endpoints so the existing widgets continue to work with OLS4
  2. Package up our new OLS4 graph and tree views (which will/do use the OLS4 API) as new and improved widgets and help users migrate to them
  3. Both of the above?

from ols4.

udp avatar udp commented on June 11, 2024

Example of jstree endpoint

https://www.ebi.ac.uk/ols/api/ontologies/efo/terms/http%253A%252F%252Fpurl.obolibrary.org%252Fobo%252FOBA_2001024/jstree?viewMode=All&lang=en&siblings=false

[ {
  "id" : "213107182_1",
  "parent" : "#",
  "iri" : "http://www.ebi.ac.uk/efo/EFO_0000001",
  "text" : "experimental factor",
  "state" : {
    "opened" : true
  },
  "children" : false,
  "a_attr" : {
    "iri" : "http://www.ebi.ac.uk/efo/EFO_0000001",
    "ontology_name" : "efo",
    "title" : "http://www.ebi.ac.uk/efo/EFO_0000001",
    "class" : "is_a"
  },
  "ontology_name" : "efo"
}, {
  "id" : "208419688_1",
  "parent" : "213082559_1",
  "iri" : "http://purl.obolibrary.org/obo/HP_0003674",
  "text" : "Onset",
  "state" : {
    "opened" : true
  },
  "children" : false,
  "a_attr" : {
    "iri" : "http://purl.obolibrary.org/obo/HP_0003674",
    "ontology_name" : "efo",
    "title" : "http://purl.obolibrary.org/obo/HP_0003674",
    "class" : "is_a"
  },
  "ontology_name" : "efo"
}, {
  "id" : "208425589_2",
  "parent" : "208419688_1",
  "iri" : "http://purl.obolibrary.org/obo/OBA_2001024",
  "text" : "age of onset of Huntington disease",
  "state" : {
    "opened" : true,
    "selected" : true
  },
  "children" : false,
  "a_attr" : {
    "iri" : "http://purl.obolibrary.org/obo/OBA_2001024",
    "ontology_name" : "efo",
    "title" : "http://purl.obolibrary.org/obo/OBA_2001024",
    "class" : "is_a"
  },
  "ontology_name" : "efo"
}, {
  "id" : "208419547_1",
  "parent" : "213107182_1",
  "iri" : "http://purl.obolibrary.org/obo/BFO_0000020",
  "text" : "material property",
  "state" : {
    "opened" : true
  },
  "children" : false,
  "a_attr" : {
    "iri" : "http://purl.obolibrary.org/obo/BFO_0000020",
    "ontology_name" : "efo",
    "title" : "http://purl.obolibrary.org/obo/BFO_0000020",
    "class" : "is_a"
  },
  "ontology_name" : "efo"
}, {
  "id" : "196752229_1",
  "parent" : "211334957_1",
  "iri" : "http://www.ebi.ac.uk/efo/EFO_0001444",
  "text" : "measurement",
  "state" : {
    "opened" : true
  },
  "children" : false,
  "a_attr" : {
    "iri" : "http://www.ebi.ac.uk/efo/EFO_0001444",
    "ontology_name" : "efo",
    "title" : "http://www.ebi.ac.uk/efo/EFO_0001444",
    "class" : "is_a"
  },
  "ontology_name" : "efo"
}, {
  "id" : "213082559_1",
  "parent" : "211349078_1",
  "iri" : "http://www.ebi.ac.uk/efo/EFO_0004949",
  "text" : "clinical temporal measurement",
  "state" : {
    "opened" : true
  },
  "children" : false,
  "a_attr" : {
    "iri" : "http://www.ebi.ac.uk/efo/EFO_0004949",
    "ontology_name" : "efo",
    "title" : "http://www.ebi.ac.uk/efo/EFO_0004949",
    "class" : "is_a"
  },
  "ontology_name" : "efo"
}, {
  "id" : "211349078_1",
  "parent" : "196752229_1",
  "iri" : "http://www.ebi.ac.uk/efo/EFO_0000719",
  "text" : "temporal measurement",
  "state" : {
    "opened" : true
  },
  "children" : false,
  "a_attr" : {
    "iri" : "http://www.ebi.ac.uk/efo/EFO_0000719",
    "ontology_name" : "efo",
    "title" : "http://www.ebi.ac.uk/efo/EFO_0000719",
    "class" : "is_a"
  },
  "ontology_name" : "efo"
}, {
  "id" : "211334957_1",
  "parent" : "213107182_1",
  "iri" : "http://purl.obolibrary.org/obo/IAO_0000030",
  "text" : "information entity",
  "state" : {
    "opened" : true
  },
  "children" : false,
  "a_attr" : {
    "iri" : "http://purl.obolibrary.org/obo/IAO_0000030",
    "ontology_name" : "efo",
    "title" : "http://purl.obolibrary.org/obo/IAO_0000030",
    "class" : "is_a"
  },
  "ontology_name" : "efo"
}, {
  "id" : "208425589_1",
  "parent" : "208419547_1",
  "iri" : "http://purl.obolibrary.org/obo/OBA_2001024",
  "text" : "age of onset of Huntington disease",
  "state" : {
    "opened" : true,
    "selected" : true
  },
  "children" : false,
  "a_attr" : {
    "iri" : "http://purl.obolibrary.org/obo/OBA_2001024",
    "ontology_name" : "efo",
    "title" : "http://purl.obolibrary.org/obo/OBA_2001024",
    "class" : "is_a"
  },
  "ontology_name" : "efo"
} ]

Screenshot 2022-10-26 at 23 07 35

from ols4.

udp avatar udp commented on June 11, 2024

Preliminary implementation is in OLS4 now; needs testing against OLS3 API

from ols4.

udp avatar udp commented on June 11, 2024

@srobb1 Are you using the tree view from https://github.com/EBISPOT/OLS-treeview or has it been modified? I just tried the tree view from the repo and it doesn't provide the viewMode=All parameter, so returns no results, but on your planosphere website it does provide the viewMode=All parameter.

from ols4.

srobb1 avatar srobb1 commented on June 11, 2024

Hi @udp,
I downloaded and set this up ages ago. The sys date on my ols-treeview.js is Mar 23, 2020, and there is a comment in the code near the top that says: // 2011-08-24

I can't remember if I modified it. Here is the code I am currently using: https://github.com/srobb1/tripal_ontologyPages/tree/master/theme/js/OLS-treeview.

Ah, I did modify it, you can see here for in my commit which contains ols-treeview.js. I did add +'/jstree?viewMode=All' ;

Sofia

from ols4.

udp avatar udp commented on June 11, 2024

Thanks @srobb1, that makes a lot of sense. We should update the OLS-treeview component to add ?viewMode=All as it is broken at the moment even with OLS3. I see you already have an issue open there so we'll definitely get around to it.

With regards to OLS4, the backwards compatible jstree endpoint is now implemented and I have checked it against the unmodified OLS3 tree view widget, which seems to work correctly. I'm now working on the graph view and I'm very close to having a working implementation. So it looks like we will be able to deploy OLS4 at EBI without any work required from existing users of the tree and graph view components.

from ols4.

srobb1 avatar srobb1 commented on June 11, 2024

@udp

Ok. So I should not be affected, but Is this something I should be looking into updating? When you have completed your deployment could you point me to the documentation. Or if there is documentation now? If I am understanding what is happening, OLS is being updated to OLS4 and the api calls that the widgets are making were going to not work, but now it seems like they will still be working. Are there new preferred widgets I should be looking at updating my site with?

Thank you for taking a few minutes to walk me through this. I greatly appreciate your time.

Sofia

from ols4.

udp avatar udp commented on June 11, 2024

Hi @srobb1,

Sorry, you were pulled into this discussion when we were still deciding what to do so I appreciate this has been confusing. OLS is being updated to OLS4 next year, but we are in the process of implementing the OLS3 APIs in OLS4 for compatibility. So the API calls that the widgets are making will continue to work identically and there will be nothing to do from your end. We are actively testing the widgets as part of our OLS4 development to make sure this is the case.

In the future we would like to develop new widgets so we can redesign them and add new features, but that will not be for some time after OLS4 is released. We have no plans to deprecate the OLS3 API, even after those new widgets are released, so you will be able to migrate to them as and when you desire to. The OLS3 API is here to stay. :-)

cheers,

James

from ols4.

udp avatar udp commented on June 11, 2024

Closing this as we now have no plans to drop the jstree endpoint; it will be supported as normal in OLS4 and the widgets will continue to function.

from ols4.

srobb1 avatar srobb1 commented on June 11, 2024

Thank you very much. We really love the widgets and are very happy to have them on our site. We will be watching for the new widgets in the future.

from ols4.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.