Giter Site home page Giter Site logo

Comments (11)

slavaschmidt avatar slavaschmidt commented on August 11, 2024 1

@zyv you're right, but unfortunately I don't know how to build the SBT plugin which must be build for scala 2.10 without cross-building the whole project. If you have an idea, it would be cool.

from api-first-hand.

slavaschmidt avatar slavaschmidt commented on August 11, 2024

Hi!

Could you please try with sbt publishLocal without "plus" sign?

from api-first-hand.

SellamiRami avatar SellamiRami commented on August 11, 2024

Thank you @slavaschmidt for your response.

It successfully works.

Could you please explain to me why it doesn't work with the "+" since in the ReadMe file it is written with it?

from api-first-hand.

zyv avatar zyv commented on August 11, 2024

@SellamiRami

> help +
+ <command>
	Runs <command> for each Scala version specified for cross-building.

	For each string in `crossScalaVersions` in the current project, this command sets the
	`scalaVersion` of all projects to that version, reloads the build, and
	executes <command>.  When finished, it reloads the build with the original
	Scala version.

	See also `help ++`

My understanding is that Play framework is not compatible with Scala 2.10 since version 2.5, but because of the plus sign, sbt attempts to build for Scala 2.10 as well.

I guess this means that my commit in #45 is wrong then, and one should remove Scala 2.10 compatibility if it is no longer supported, instead of removing + from the publishLocal command.

@slavaschmidt ?

from api-first-hand.

slavaschmidt avatar slavaschmidt commented on August 11, 2024

@zyv Yes, that's correct. We cannot build for scala 2.10 because it's not supported by play itself.
But I think you removed the + sign in the #45, so why is it wrong then?

from api-first-hand.

zyv avatar zyv commented on August 11, 2024

Well, I thought that instead of restricting the build to the current version of Scala by removing the plus, one should simply remove cross-building from the build system, if it is so, that the project will only ever be compatible with the current version of Play, which itself will only ever be compatible with the current version of Scala.

However, I lack background in Scala to decide what's best. If you think that removing the plus sign is better, because cross-building will be used again in the future, then everything is alright :-)

from api-first-hand.

LappleApple avatar LappleApple commented on August 11, 2024

Hi @zyv, just following up on @slavaschmidt's point/openness to ideas on this. If you'd like to share, it would be great! Otherwise, I'll close this thread...

from api-first-hand.

zyv avatar zyv commented on August 11, 2024

@LappleApple sorry, no idea; lacking background in as far as Scala ecosystem is concerned, I still don't quite get it why some sbt plugin must be built for Scala 2.10 and not Scala 2.11, and besides see #47 :-/

from api-first-hand.

slavaschmidt avatar slavaschmidt commented on August 11, 2024

Just to clarify a bit: sbt 0.13 does not support scala 2.11 or 2.12 (at least not officially). The plugin code must be scala 2.10 and must be compiled with scala 2.10

from api-first-hand.

gipeshka avatar gipeshka commented on August 11, 2024

Would updating to sbt 0.13.13 solve the issue?
Directly on 2.12 page they say 0.13.13 should be ok
http://www.scala-lang.org/news/2.12.0

from api-first-hand.

slavaschmidt avatar slavaschmidt commented on August 11, 2024

@gipeshka Well, it's complicated :) The SBT plugin supports different Scala versions as a build tool.
The tool itself is a different story. The SBT supports Scala 2.12 but it's source code does not.
Imagine Java 8 would not be compatible with Java 6 and maven sources would be Java 6. Then you can build whatever you want with maven but you must build maven itself with Java 6, right?

from api-first-hand.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.