Extension causes REAPER crash with Language Pack installed

[ebu]

Extension causes REAPER crash with Language Pack installed

[firthm01]

The above two commits will need reverting when this issue is resolved (warnings on website and on repo README)

[merktj]

The const char* LocalizeString(const char* src_string, const char* section, int flagsOptional function is not available in the currently used API v5.961/x64.
In the latest API version it's there.

Is there a reason for using the old API, respectively does something speak against updating it?

[merktj]

The const char* LocalizeString(const char* src_string, const char* section, int flagsOptional got introduced with API v6.10 and updating the API would not ensure backwards compatibility.

The probable easiest way to work around this is to insert the menues directly by their position index, without searching the index by string comparisons.

[firthm01]

The reason we avoided using indexes originally is that anything else that adds menu options itself would throw this out (including new features in future versions of REAPER.)
I think hard-coded indexes would be a good fallback however for when the search strings are not found (rather than the crash it currently causes!) This way, at least if those searched menu items disappear/change name in future versions of REAPER, we still have some way to present our options even if they might end up in the wrong position.
It would probably be good to put in some asserts in there (or some other method of flagging an issue) so that if the search strings are found but the index does not match the hard-coded fallback index, we will be alerted to it and can update them.