Comments (5)
Should we also be specifying the Python version as part of this? e.g. https://pip.pypa.io/en/stable/reference/pip_install/#requirement-specifiers says that in the requirements.txt
file used by pip you can specify something like SomeProject ==5.4 ; python_version < '2.7'
where for us SomeProject
is this project.
from ebu-tt-live-toolkit.
As far as I understand the related PEP 508, this specifier means that the requirement (an explicitely specified version or otherwise the latest version of it) is only installed if the mentioned Python version matches the filter condition. It does not mean that a version of the requirement is selected/installed, that supports the specified Python version (which would be great).
So the specifier would only allow to not install the LIT itself in case e.g. Python 3 was used....but I think that the version hint in the README is sufficient here. We could just change the "2.7+" to "2.7" to indicate that Python 3 is not supported by this branch.
from ebu-tt-live-toolkit.
Yeah, I guess you're right. Maybe the best option is a Makefile step that checks the python version number is within acceptable bounds. Cheeky stackoverflow search reveals https://stackoverflow.com/questions/4933285/how-to-detemine-python-version-in-makefile with a few ways to do it.
from ebu-tt-live-toolkit.
Using the Makefile seems to be the best way to abort using the wrong Python version as early as possible. The sys.version_info
approach seems to be more elegant than parsing python --version
. Maybe it makes also sense to do the actual version number comparison in Python itself then.
from ebu-tt-live-toolkit.
I think the work needed to close this issue was done. It may be nice to check the python version, but in Python 3 with e.g. poetry, there are known ways to do this, so I don't think it's helpful to hold this issue open waiting for some fix that's never coming, for Python 2.7. Closing as done, with thanks again to @spoeschel .
from ebu-tt-live-toolkit.
Related Issues (20)
- EBUTT3DocumentSequence: format ERR_DOCUMENT_NOT_COMPATIBLE strings HOT 1
- Python 3 branch: mention required Python 3 version HOT 2
- Add BDDs for Resequencer init document
- Create reusable mechanism for configuring output sequence numbers
- layout element is wrongly allowed to be empty
- Fix up code to pass pep8 and add flake8 as a build check
- Add `fillLineGap` and `activeArea` IMSC attributes
- XSD issue: ttm:name element being put in global namespace
- [DOCUMENTATION] "make clean" deletes project homepage HOT 3
- [DOCUMENTATION] address minor Sphinx build warnings
- Python 3: "make template" fails HOT 3
- 'invalid syntax' error from nltk HOT 1
- rename master branch to main
- Tests fail with newer Pytest-BDD versions HOT 1
- Add deployment build
- pyxb EOL notification HOT 2
- pytest-capturelog no longer available in distribution? HOT 2
- Compute the inherited value of `ttm:role`
- change from TravisCI to another CI/CD provider
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from ebu-tt-live-toolkit.