Don't use built-in fuction names (type, id, ...) as variable names

[eclecticiq]

Don't use built-in fuction names (type, id, ...) as variable names

[wbolster]

Amen, with one exception: signatures of functions and methods that are considered "public API" may contain arguments named type, id, and so on. This makes for a much friendlier API than doing unnecessary hacks like forcing callers to type type_ or id_ instead.

(Fwiw, many Python libs and also the stdlib behave like this.)

So this is fine:

class Foo(object):
    def __init__(self, id, name):
        self.id, self.name = id, name

... but this is not:

my_foo = Foo(...)
id = my_foo.id
do_something_with(id)

[traut]

judging by http://landscape.io overview, this is mostly fixed in the current codebase: id/type are only used as constructor arguments.

So I consider this issue to be fixed and the approach should be adopted as practice.