BIRT/JavaScript: Rhino engine, activate the "Version ES6" as new default for the BIRT-Rhino-engine

[speckyspooky]

BIRT/JavaScript: Rhino engine, activate the "Version ES6" as new default for the BIRT-Rhino-engine

[wimjongman]

Sure, but let's do it early in 4.16.

[speckyspooky]

Henning, I would never use a boolean for that. In every case I will implements a string for the key-value.
The key option will be oriented in full at the version-configuration of the Rhino-Engine:

JavaScript - Verions (Rhino-Engine) Master

• The Version number will be the key of the property, not the internal version number.
• Version: 1.1 (internal Rhino-Engine version no.: 100)
• Version: 1.1 (internal Rhino-Engine version no.: 110)
• Version: 1.2 (internal Rhino-Engine version no.: 120)
• Version: 1.3 (internal Rhino-Engine version no.: 130)
• Version: 1.4 (internal Rhino-Engine version no.: 140)
• Version: 1.5 (internal Rhino-Engine version no.: 150)
• Version: 1.6 (internal Rhino-Engine version no.: 160)
• Version: 1.7 (internal Rhino-Engine version no.: 170)
• Version: 1.8 (internal Rhino-Engine version no.: 180, Rhnio-Engine default)
• Version: ES6 (internal Rhino-Engine version no.: 200, BIRT-default 4.16)

[hvbtup]

But there would be currently no way to change the version back to another version...

Thomas, do you mean that the ES version must be set when BIRT as a whole initializes and thus cannot be changed per report?

I'd prefer (if it is possible) to be able to set this on a per-report basis.

Anyway, if it is only configurable for BIRT as a whole, we should allow a system property (say, birt.ecmascript.version to manually select a different version, to allow backward compatibility where necessary.

I'm +1 for deferring it to 4.16.

I think this is logically a change to the ROM (just like the improvement to support diagonal borders, btw), so we should increase the version number in the rptdesign files.

The reason is:
The BIRT releases used for designing the report and for running the report may differ (eg we still usually use BIRT 4.2.1 for developing reports).
If a report is developed in a BIRT 4.16 environment with ES6 support, it will usually not run in an BIRT 4.15 or older environment.

Increasing the version number means (at least I understand it that way):
This report design might not work with a BIRT release which only knows lower version numbers.
To make an rptdesign file work with older BIRT releases then means to manually edit the file and decrease the version number and hope for the best.

[speckyspooky]

Yes, I will switch the change to 4.16.

@hvbtup: Henning, what would be a good place for the configuration because it must be work multiple with eclipse, runtime (standard & OSGI).
And yes, the classes are very strong splitted. So there is no easy way to exchange user properties (I found currently no way for it.)

[hvbtup]

As I said, I think it suffices if the default ES version can be overridden with a system property.

[speckyspooky]

Of course, I switched the change to BIRT 4.16. I will also add a system-property to switch from default to other older Rhino-JS-version.

[hvbtup]

Please specify the switch in such a way that the version can be specified as a string or something, not a boolean. This way it will be future-proof.

[SteveSchafer-Innovent]

+1 for ES6. Been wanting this for a long time.

[wimjongman]

Hey Steve!

[speckyspooky]

I will create a PR with it after publishing of 4.15.

[speckyspooky]

The change is merged to the master branche with PR #1682