Comments (11)
Sure, but let's do it early in 4.16.
from birt.
Henning, I would never use a boolean for that. In every case I will implements a string for the key-value.
The key option will be oriented in full at the version-configuration of the Rhino-Engine:
JavaScript - Verions (Rhino-Engine) Master
- The Version number will be the key of the property, not the internal version number.
- Version: 1.1 (internal Rhino-Engine version no.: 100)
- Version: 1.1 (internal Rhino-Engine version no.: 110)
- Version: 1.2 (internal Rhino-Engine version no.: 120)
- Version: 1.3 (internal Rhino-Engine version no.: 130)
- Version: 1.4 (internal Rhino-Engine version no.: 140)
- Version: 1.5 (internal Rhino-Engine version no.: 150)
- Version: 1.6 (internal Rhino-Engine version no.: 160)
- Version: 1.7 (internal Rhino-Engine version no.: 170)
- Version: 1.8 (internal Rhino-Engine version no.: 180, Rhnio-Engine default)
- Version: ES6 (internal Rhino-Engine version no.: 200, BIRT-default 4.16)
from birt.
But there would be currently no way to change the version back to another version...
Thomas, do you mean that the ES version must be set when BIRT as a whole initializes and thus cannot be changed per report?
I'd prefer (if it is possible) to be able to set this on a per-report basis.
Anyway, if it is only configurable for BIRT as a whole, we should allow a system property (say, birt.ecmascript.version
to manually select a different version, to allow backward compatibility where necessary.
I'm +1 for deferring it to 4.16.
I think this is logically a change to the ROM (just like the improvement to support diagonal borders, btw), so we should increase the version number in the rptdesign files.
The reason is:
The BIRT releases used for designing the report and for running the report may differ (eg we still usually use BIRT 4.2.1 for developing reports).
If a report is developed in a BIRT 4.16 environment with ES6 support, it will usually not run in an BIRT 4.15 or older environment.
Increasing the version number means (at least I understand it that way):
This report design might not work with a BIRT release which only knows lower version numbers.
To make an rptdesign file work with older BIRT releases then means to manually edit the file and decrease the version number and hope for the best.
from birt.
Yes, I will switch the change to 4.16.
@hvbtup: Henning, what would be a good place for the configuration because it must be work multiple with eclipse, runtime (standard & OSGI).
And yes, the classes are very strong splitted. So there is no easy way to exchange user properties (I found currently no way for it.)
from birt.
As I said, I think it suffices if the default ES version can be overridden with a system property.
from birt.
Of course, I switched the change to BIRT 4.16. I will also add a system-property to switch from default to other older Rhino-JS-version.
from birt.
Please specify the switch in such a way that the version can be specified as a string or something, not a boolean. This way it will be future-proof.
from birt.
+1 for ES6. Been wanting this for a long time.
from birt.
Hey Steve!
from birt.
I will create a PR with it after publishing of 4.15.
from birt.
The change is merged to the master branche with PR #1682
from birt.
Related Issues (20)
- Where is "null value" check box parameter in debug mode ??? 4.14 HOT 3
- 4.17 Releng HOT 1
- Use edge as default browser and use modern help HOT 3
- Show the DataView when a new report is created
- body/label/text-property is not localized in XLSX output HOT 4
- Excel, Apache POI 5.2.3 - PageMargin is changed to a new parameter list of methods HOT 1
- Excel, image scaling is wrong when only one image dimension is set HOT 1
- Excel, small images will be scalled to large images and lose the original size HOT 2
- Can units be added on Y-axis?
- Can it add collapsible effect feature?
- Does the row header support sorting and filtering functions?
- Excel, enhance the handling of image alignment - horizontal & vertical alignment HOT 2
- Birt Report Header Issue HOT 2
- Excel emitter configuration: enhance the designer "advanced property"-register to setup the configuration HOT 1
- securityDomain should be null if setSecurityController() was never called HOT 3
- Excel emitter configuration (part 2, #1770): addition advanced properties HOT 1
- Crash when rendering report HOT 3
- Issue on Double-Byte-Characters: text-parameters do not display correctly on PDF/XLS/XLSX/DOCX (e.g. CN, GR, DE-Umlaut) HOT 8
- Excel-emitter (Spudsoft): Grids and tables with merged rows and image can cause NPE HOT 1
- ClassCastException: Report-processing with "HTML-table-structures" cause exception if the structure contains comments HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from birt.