Comments (6)
Yes, of course with that extension it works. I have done a small change at 2 classes which checks "external" sources
and added the "data:"-URL-protocol key and the first try shows the old behavior where the svg-data-URL will be embedded.
It seems to me that the behavior is changed due to the changed tidy-parser behavior and therefore we got some effects.
I will take a look into the file extension way because there we would need a special role to get the extension from the URL.
from birt.
My sense is that inline, option 1, would be better and more like what's specified in the report source.
from birt.
If you do Open Image in New Tab it shows the content:
If I copy the content into a file, including adding the XML header, it still renders like this:
Only if the file extension is .svg does it render correctly:
from birt.
@merks
I need your mind because I have 2 ways to solved it but which one is the better way (?)
Option 1) Restore the behavior like BIRT 4.14 with embedded SVG directly into the preview - 2 changes
- changes are very small
Option 2) Change the behavior to get the correct file extension and use the file integration - 1 change
- special case for the file extension creation
- only "SVG" necessary because the embedded raster-images can be read directly without file extension
Attached the screen of the 2 changes on my notepad for compare.
My favorit would be "Option 2)" but I'm completely free and need a second opinion.
from birt.
PR #1605 created to fix the issue.
from birt.
The retest with the nightly build was successful and the images will be displayed according to BIRT4.14
from birt.
Related Issues (20)
- Can't generate Excel file: Could not auto-size column. Make sure the column was tracked prior to auto-sizing the column. HOT 1
- Getting NoSuchmethodError: "TTFReader.loadTTF" after updating BIRT runtime 4.10 to 4.15 HOT 1
- Errors in reports when upgrading BIRT Runtime from 4.10 to 4.15 HOT 2
- Expression Builder, Column Binding, sorting option - add additional sort option "Sort descending" HOT 1
- How can i fix this ReportServiceException HOT 2
- scripted data source 数据集只加载一次
- Out of memory error when creating a chart HOT 58
- Where is "null value" check box parameter in debug mode ??? 4.14 HOT 3
- 4.17 Releng HOT 1
- Use edge as default browser and use modern help HOT 3
- Show the DataView when a new report is created
- body/label/text-property is not localized in XLSX output HOT 4
- Excel, Apache POI 5.2.3 - PageMargin is changed to a new parameter list of methods HOT 1
- Excel, image scaling is wrong when only one image dimension is set HOT 1
- Excel, small images will be scalled to large images and lose the original size HOT 2
- Can units be added on Y-axis?
- Can it add collapsible effect feature?
- Does the row header support sorting and filtering functions?
- Excel, enhance the handling of image alignment - horizontal & vertical alignment HOT 2
- Birt Report Header Issue HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from birt.