Giter Site home page Giter Site logo

Comments (6)

speckyspooky avatar speckyspooky commented on June 30, 2024 1

Yes, of course with that extension it works. I have done a small change at 2 classes which checks "external" sources
and added the "data:"-URL-protocol key and the first try shows the old behavior where the svg-data-URL will be embedded.

It seems to me that the behavior is changed due to the changed tidy-parser behavior and therefore we got some effects.

I will take a look into the file extension way because there we would need a special role to get the extension from the URL.

from birt.

merks avatar merks commented on June 30, 2024 1

My sense is that inline, option 1, would be better and more like what's specified in the report source.

from birt.

merks avatar merks commented on June 30, 2024

If you do Open Image in New Tab it shows the content:

image

If I copy the content into a file, including adding the XML header, it still renders like this:

image

Only if the file extension is .svg does it render correctly:

image

from birt.

speckyspooky avatar speckyspooky commented on June 30, 2024

@merks
I need your mind because I have 2 ways to solved it but which one is the better way (?)

Option 1) Restore the behavior like BIRT 4.14 with embedded SVG directly into the preview - 2 changes

  • changes are very small

Option 2) Change the behavior to get the correct file extension and use the file integration - 1 change

  • special case for the file extension creation
  • only "SVG" necessary because the embedded raster-images can be read directly without file extension

Attached the screen of the 2 changes on my notepad for compare.
My favorit would be "Option 2)" but I'm completely free and need a second opinion.

old-behavior-vs-new

from birt.

speckyspooky avatar speckyspooky commented on June 30, 2024

PR #1605 created to fix the issue.

from birt.

speckyspooky avatar speckyspooky commented on June 30, 2024

The retest with the nightly build was successful and the images will be displayed according to BIRT4.14

from birt.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.