UIComponentTag.isSuppressed() performance

[eclipse-ee4j]

UIComponentTag.isSuppressed() performance

[ren-zhijun-oracle]

• Issue Imported From: https://github.com/javaserverfaces/mojarra/issues/36
• Original Issue Raised By:@javaserverfaces
• Original Issue Assigned To: @glassfishrobot
• Original Issue Closed By:@javaserverfaces

[ren-zhijun-oracle]

@javaserverfaces Commented
Reported by adamwiner

[ren-zhijun-oracle]

@javaserverfaces Commented
@rlubke said:
Assigned.

[ren-zhijun-oracle]

@javaserverfaces Commented
@rlubke said:
Created an attachment (id=18)
Proposed patch

[ren-zhijun-oracle]

@javaserverfaces Commented
@rlubke said:
Attached change bundle based on Adam's report.

[ren-zhijun-oracle]

@javaserverfaces Commented
@edburns said:
I like how shouldBeSuppresed() doesn't mutate the object state.

r=edburns

[ren-zhijun-oracle]

@javaserverfaces Commented
adamwiner said:
One recommended change: pass the method variable "parentTag" (of type UIComponentTag) in
doStartTag() to shouldBeSuppressed(), and use that instead of the "parent" instance variable. This'll
handle scenarios where a non-UIComponentTag tag comes between two UIComponentTags.

[ren-zhijun-oracle]

@javaserverfaces Commented
@rlubke said:
Thanks for pointing that out. I've updated accordingly.

[ren-zhijun-oracle]

@javaserverfaces Commented
@manfredriem said:
Closing issue out

[ren-zhijun-oracle]

@javaserverfaces Commented
File: cb.txt
Attached By: @rlubke

[ren-zhijun-oracle]

@javaserverfaces Commented
This issue was imported from java.net JIRA JAVASERVERFACES-32

[ren-zhijun-oracle]

@javaserverfaces Commented
Marked as fixed on Wednesday, April 19th 2006, 5:44:08 am