Comments (4)
That should be fine. I'm also not sure why there can be different types for the begin and end iterator. I know that the STL allows such things but it is not possible with our implementation. I would also remove that.
from iceoryx.
It seems the span
has not enough tests. I guess the check for a nullptr
should only be done when the It
and End
are pointer types ... and event then the check is wrong. Can you create a patch?
from iceoryx.
I can definitely add a patch and some unit tests. I'm not entirely sure I understand the intent of the original assert though. My suggestion would be to change it to simply ...
assert(begin <= end);
Is that acceptable?
from iceoryx.
@elBoberido #2255 is ready for review
from iceoryx.
Related Issues (20)
- publisher got error after loaned 8 sample HOT 2
- Race condition between ProbeProcessAliveWithSigTerm in RouDi and SignalWatcher singleton in applications HOT 5
- Out-of-bounds memory access in UsedChunkList HOT 9
- Request server received no valid server port from RouDi HOT 2
- It is possible to specify a queue size greater than 256 HOT 2
- Move iceoryx2 cxx addendum headers into iceoryx
- iox::function claims to support moving functions, but doesn't HOT 5
- Building iceoryx with bazel on Windows is broken
- Port iceoryx to bzlmod
- Compilation Conflict with Apache Arrow from ENUM macro
- Add std::atomic abstraction
- The wrong status is being transmitted HOT 5
- [ Error ]: ICEORYX error! MEPOO__MEMPOOL_CHUNKSIZE_MUST_BE_MULTIPLE_OF_CHUNK_MEMORY_ALIGNMENT HOT 6
- message_filters::Synchronizer failed when roudi client is enabled ? HOT 2
- How to setting the right val of size and count in toml config ?
- A Small Mistake in lockfree_queue.md HOT 4
- Use a Findacl.cmake to setup the dependency to libacl HOT 2
- MEPOO__MEMPOOL_GETCHUNK_POOL_IS_RUNNING_OUT_OF_CHUNKS HOT 2
- bazel build fails on macos
- Add PortThroughputIntrospectionTopic
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from iceoryx.