Regression: New formatter block formatting rules leaves ending tags of nested HTML block elements on same line; breaks existing formatting functionality.

[garretwilson]

Regression: New formatter block formatting rules leaves ending tags of nested HTML block elements on same line; breaks existing formatting functionality.

[garretwilson]

It looks like this is still broken in Eclipse 2023-09 RC1. @jjohnstn can you give me a status on this? I was so excited after your work on #991, thinking that after so many years it might finally be addressed. But I'm not sure if any progress has been made since Eclipse 2023-06. Any news?

[garretwilson]

Oh no! It would appear that the changes made in #991 actually caused a regression in the existing formatting!

Before we would have Javadocs like this:

/**
 * <p>
 * blah blah blah
 * </p>
 * 
 * <pre>
 * <code>com.example.FooConcernProvider</code>
 * </pre>
 * <p>
 * more blah blah blah
 * </p>
 */

Now after #991, at least as of Eclipse 2023-09 RC1, Eclipse will unwrap the </pre> block tag, resulting in this:

/**
…
 * <pre>
 * <code>com.example.FooConcernProvider</code> </pre>
…
 */

See Javadocs in Csar.java as an example.

Now after almost a decade, not only is the issue not fixed, it is now broken worse than it was before. 😢

If you can't fix it, can at least reverse the changes in #991 so that existing formatting won't be broken?

[jjohnstn]

@garretwilson I'll take a look at it once all the postponed 4.30 M1 changes (too late for M3) are merged.

[garretwilson]

I'll take a look at it once all the postponed 4.30 M1 changes (too late for M3) are merged.

Fair enough. Thank you!