Giter Site home page Giter Site logo

Comments (28)

trancexpress avatar trancexpress commented on August 16, 2024

Links will be a big problem (the conversion tool replaces empty spaces with _, but for GitHub we need -). Also the wiki doesn't show images, even though opening an .md file with Okulardoes show images... Likely we have to give a full path link to the image...

Current state is at: https://github.com/trancexpress/eclipse.jdt.core/wiki/

from eclipse.jdt.core.

trancexpress avatar trancexpress commented on August 16, 2024

Looks like there are pages not seen in the JDT category. E.g. I found this one:

https://wiki.eclipse.org/JDT_Core_Programmer_Guide/ECJ/Lambda

from eclipse.jdt.core.

trancexpress avatar trancexpress commented on August 16, 2024

Still have to fix this one: https://github.com/trancexpress/eclipse.jdt.core/wiki/Java

There are a lot of div tags that don't work anymore. Original is: https://wiki.eclipse.org/JDT_Core/Plan/Java

from eclipse.jdt.core.

trancexpress avatar trancexpress commented on August 16, 2024

@iloveeclipse I think I fixed the biggest problems, we can check the contents next and prune outdated information. And fix other problems that I overlooked.

Overall the new wiki pages look on average worse and there are some artifacts from the migration (especially ` symbols).

https://github.com/trancexpress/eclipse.jdt.core/wiki/

from eclipse.jdt.core.

trancexpress avatar trancexpress commented on August 16, 2024

I did what I could for the committer FAQ page: https://github.com/trancexpress/eclipse.jdt.core/wiki/JDT-Core-Committer-FAQ

But there is a lot about release management. I don't know how the processes has changed with the move to GitHub (in particular I the GitHub issues seem to not offer many of the bugzilla capabilities). Or if the process still exists in general. @iloveeclipse you'll have to handle that part, either by finding someone who knows how the process works... or we just delete that part of the page / make a reference to the JDT Eclipse wiki that will eventually be deleted.

https://github.com/trancexpress/eclipse.jdt.core/wiki/Charter also has a bunch of processes based on bugzilla information. I don't know how much of it is outdated now.

from eclipse.jdt.core.

trancexpress avatar trancexpress commented on August 16, 2024

I find a lot of outdated information here: https://github.com/trancexpress/eclipse.jdt.core/wiki/JDT-Core-Index-Programmer-Guide

I've added a warning and referenced the bugs that disabled and later on removed the new index. We'll have to prune the information about the new index... if nothing is left of the page after that we delete it.

from eclipse.jdt.core.

trancexpress avatar trancexpress commented on August 16, 2024

OK, I went over the pages, fixed formatting and so on. I've added disclaimers (at the start) for pages where there is outdated information.

For the grouping/categories, I don't think there is an option. I found this feature request: community/community#23914

from eclipse.jdt.core.

trancexpress avatar trancexpress commented on August 16, 2024

@iloveeclipse this is ready for merging. It would be good to go over the pages with outdated info but I guess that can be done later on (if ever). See: https://github.com/trancexpress/eclipse.jdt.core/wiki/

I believe you'll need to add my fork as a remote, pull from my master and then force push to the JDT core wiki repository.

There might be problems with the commits already on the JDT core wiki repository though... I believe my master branch starts with no commits from the JDT core wiki repository...

from eclipse.jdt.core.

iloveeclipse avatar iloveeclipse commented on August 16, 2024

No worries, it should be straightforward with git. Will do next week.

from eclipse.jdt.core.

trancexpress avatar trancexpress commented on August 16, 2024

I've rebased my master branch on top of the JDT one. So updating the JDT core wiki should be simple now.

from eclipse.jdt.core.

trancexpress avatar trancexpress commented on August 16, 2024

@iloveeclipse I've fixed links in: https://github.com/trancexpress/eclipse.jdt.core/wiki/ECJ

Anything else here? The committer process is done now, I can push the wiki pages myself. Should I?

from eclipse.jdt.core.

iloveeclipse avatar iloveeclipse commented on August 16, 2024

Check the very first link in
https://github.com/trancexpress/eclipse.jdt.core/wiki/ECJ-Lambda

Could it be, that inter-wiki links are all broken?

from eclipse.jdt.core.

iloveeclipse avatar iloveeclipse commented on August 16, 2024

Same here, see links to JDT Core Programmer Guide/Completion
https://github.com/trancexpress/eclipse.jdt.core/wiki/ECJ-Parse

from eclipse.jdt.core.

iloveeclipse avatar iloveeclipse commented on August 16, 2024

also UnlikelyArgumentCheck link in https://github.com/trancexpress/eclipse.jdt.core/wiki/ECJ-Bindings

and

  • Analysis->Black lists / white lists
  • JDT Core Programmer Guide/ECJ/Lookups#Scopes

from eclipse.jdt.core.

trancexpress avatar trancexpress commented on August 16, 2024

Could it be, that inter-wiki links are all broken?

None of the links work out of the box after migration, all have to be adjusted manually. Its possible I've renamed pages after adjusting the links.

from eclipse.jdt.core.

iloveeclipse avatar iloveeclipse commented on August 16, 2024

None of the links work out of the box after migration

Wow, this is a major issue, have you reported it to the transition bug? Or is that JDT specific?

from eclipse.jdt.core.

iloveeclipse avatar iloveeclipse commented on August 16, 2024

If that is the case, shouldn't there be some visible "errors" generatedcin html, or "todos" in code?

from eclipse.jdt.core.

iloveeclipse avatar iloveeclipse commented on August 16, 2024

... and yes, if you can, just push to JDT wiki. There is no reason to work on private fork anymore, all the fine tuning can be done in the official repo.

from eclipse.jdt.core.

trancexpress avatar trancexpress commented on August 16, 2024

Wow, this is a major issue, have you reported it to the transition bug? Or is that JDT specific?

I think its an issue with the migration script (https://github.com/outofcontrol/mediawiki-to-gfm). Since its not related to Eclipse I assumed it makes no sense to open a bug anywhere. Its probably a special case of how GitHub wiki links work. Probably the generated .md links work fine for just markdown files. But not for the GitHub wiki pages.

If that is the case, shouldn't there be some visible "errors" generatedcin html, or "todos" in code?

There is "wikilink" text next to each link. But the link can point into nothing.

... and yes, if you can, just push to JDT wiki. There is no reason to work on private fork anymore, all the fine tuning can be done in the official repo.

OK I'll fix the issues you found and I'll push.

from eclipse.jdt.core.

iloveeclipse avatar iloveeclipse commented on August 16, 2024

Please report the link issue to the migration bug, to share our pain with others, so they are warned and may be someone could find / share a fix.

from eclipse.jdt.core.

trancexpress avatar trancexpress commented on August 16, 2024

OK, I commented here: https://gitlab.eclipse.org/eclipsefdn/helpdesk/-/issues/681#note_1086886

Wiki pages are pushed now, see: https://github.com/eclipse-jdt/eclipse.jdt.core/wiki

from eclipse.jdt.core.

iloveeclipse avatar iloveeclipse commented on August 16, 2024

@stephan-herrmann : regarding structure: I believe it can help if you clone the wiki repo locally to check where the actual wiki files are. Clone https://github.com/eclipse-jdt/eclipse.jdt.core.wiki.git and import the project.

image

from eclipse.jdt.core.

trancexpress avatar trancexpress commented on August 16, 2024

@stephan-herrmann , for adding links please check the existing ones, e.g. to link a page and a subpage:

[JDT Core Programmer Guide/ECJ/Completion\#Lambda Specifics](ECJ-Completion#Lambda-Specifics "wikilink")

Relative paths to the links don't work for GitHub, or at least I couldn't get them to work. This is painful when using a markdown editor, since the links can't be tested in the editor...

The hierarchy of pages is gone yes, best I could do was to add prefixes to page names. E.g., ECJ-AST.

Also some of the nicer html formattings from the Eclipse wiki didn't make it through the migration. E.g. some color tags still exist but GitHub doesn't show colors.

from eclipse.jdt.core.

stephan-herrmann avatar stephan-herrmann commented on August 16, 2024

... "painful" describes it well. I thought github wiki was mature software, but a preview speaking a different language from the saved version is ... ("embarrassing"? ...? ).

from eclipse.jdt.core.

trancexpress avatar trancexpress commented on August 16, 2024

I thought github wiki was mature software

During the migration, to me at least the wiki functionality looked more like an afterthought. Overall GitHub doesn't seem to be the best platform for big projects like Eclipse, but not much to do about it at this point.

from eclipse.jdt.core.

iloveeclipse avatar iloveeclipse commented on August 16, 2024

embarrassing

Why? It delivers minimum viable product to get people locked & money from organizations that follow the hype. That's how the IT world works since decades. Nothing really embarrassing. Also remember who is the current github owner is and which track of record it has delivering buggy software to customers :-)

from eclipse.jdt.core.

trancexpress avatar trancexpress commented on August 16, 2024

Anything else to discuss here? If not, closing the issue.

from eclipse.jdt.core.

iloveeclipse avatar iloveeclipse commented on August 16, 2024

No, I think if we find a new issue we can fix in the wiki itself.
Thanks you Simeon!

from eclipse.jdt.core.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.