Comments (28)
Links will be a big problem (the conversion tool replaces empty spaces with _
, but for GitHub
we need -
). Also the wiki doesn't show images, even though opening an .md
file with Okular
does show images... Likely we have to give a full path link to the image...
Current state is at: https://github.com/trancexpress/eclipse.jdt.core/wiki/
from eclipse.jdt.core.
Looks like there are pages not seen in the JDT category. E.g. I found this one:
https://wiki.eclipse.org/JDT_Core_Programmer_Guide/ECJ/Lambda
from eclipse.jdt.core.
Still have to fix this one: https://github.com/trancexpress/eclipse.jdt.core/wiki/Java
There are a lot of div
tags that don't work anymore. Original is: https://wiki.eclipse.org/JDT_Core/Plan/Java
from eclipse.jdt.core.
@iloveeclipse I think I fixed the biggest problems, we can check the contents next and prune outdated information. And fix other problems that I overlooked.
Overall the new wiki pages look on average worse and there are some artifacts from the migration (especially ` symbols).
https://github.com/trancexpress/eclipse.jdt.core/wiki/
from eclipse.jdt.core.
I did what I could for the committer FAQ page: https://github.com/trancexpress/eclipse.jdt.core/wiki/JDT-Core-Committer-FAQ
But there is a lot about release management. I don't know how the processes has changed with the move to GitHub (in particular I the GitHub issues seem to not offer many of the bugzilla capabilities). Or if the process still exists in general. @iloveeclipse you'll have to handle that part, either by finding someone who knows how the process works... or we just delete that part of the page / make a reference to the JDT Eclipse wiki that will eventually be deleted.
https://github.com/trancexpress/eclipse.jdt.core/wiki/Charter also has a bunch of processes based on bugzilla information. I don't know how much of it is outdated now.
from eclipse.jdt.core.
I find a lot of outdated information here: https://github.com/trancexpress/eclipse.jdt.core/wiki/JDT-Core-Index-Programmer-Guide
I've added a warning and referenced the bugs that disabled and later on removed the new index. We'll have to prune the information about the new index... if nothing is left of the page after that we delete it.
from eclipse.jdt.core.
OK, I went over the pages, fixed formatting and so on. I've added disclaimers (at the start) for pages where there is outdated information.
For the grouping/categories, I don't think there is an option. I found this feature request: community/community#23914
from eclipse.jdt.core.
@iloveeclipse this is ready for merging. It would be good to go over the pages with outdated info but I guess that can be done later on (if ever). See: https://github.com/trancexpress/eclipse.jdt.core/wiki/
I believe you'll need to add my fork as a remote, pull from my master
and then force push to the JDT core wiki repository.
There might be problems with the commits already on the JDT core wiki repository though... I believe my master
branch starts with no commits from the JDT core wiki repository...
from eclipse.jdt.core.
No worries, it should be straightforward with git. Will do next week.
from eclipse.jdt.core.
I've rebased my master
branch on top of the JDT one. So updating the JDT core wiki should be simple now.
from eclipse.jdt.core.
@iloveeclipse I've fixed links in: https://github.com/trancexpress/eclipse.jdt.core/wiki/ECJ
Anything else here? The committer process is done now, I can push the wiki pages myself. Should I?
from eclipse.jdt.core.
Check the very first link in
https://github.com/trancexpress/eclipse.jdt.core/wiki/ECJ-Lambda
Could it be, that inter-wiki links are all broken?
from eclipse.jdt.core.
Same here, see links to JDT Core Programmer Guide/Completion
https://github.com/trancexpress/eclipse.jdt.core/wiki/ECJ-Parse
from eclipse.jdt.core.
also UnlikelyArgumentCheck link in https://github.com/trancexpress/eclipse.jdt.core/wiki/ECJ-Bindings
and
- Analysis->Black lists / white lists
- JDT Core Programmer Guide/ECJ/Lookups#Scopes
from eclipse.jdt.core.
Could it be, that inter-wiki links are all broken?
None of the links work out of the box after migration, all have to be adjusted manually. Its possible I've renamed pages after adjusting the links.
from eclipse.jdt.core.
None of the links work out of the box after migration
Wow, this is a major issue, have you reported it to the transition bug? Or is that JDT specific?
from eclipse.jdt.core.
If that is the case, shouldn't there be some visible "errors" generatedcin html, or "todos" in code?
from eclipse.jdt.core.
... and yes, if you can, just push to JDT wiki. There is no reason to work on private fork anymore, all the fine tuning can be done in the official repo.
from eclipse.jdt.core.
Wow, this is a major issue, have you reported it to the transition bug? Or is that JDT specific?
I think its an issue with the migration script (https://github.com/outofcontrol/mediawiki-to-gfm). Since its not related to Eclipse I assumed it makes no sense to open a bug anywhere. Its probably a special case of how GitHub wiki links work. Probably the generated .md
links work fine for just markdown files. But not for the GitHub wiki pages.
If that is the case, shouldn't there be some visible "errors" generatedcin html, or "todos" in code?
There is "wikilink"
text next to each link. But the link can point into nothing.
... and yes, if you can, just push to JDT wiki. There is no reason to work on private fork anymore, all the fine tuning can be done in the official repo.
OK I'll fix the issues you found and I'll push.
from eclipse.jdt.core.
Please report the link issue to the migration bug, to share our pain with others, so they are warned and may be someone could find / share a fix.
from eclipse.jdt.core.
OK, I commented here: https://gitlab.eclipse.org/eclipsefdn/helpdesk/-/issues/681#note_1086886
Wiki pages are pushed now, see: https://github.com/eclipse-jdt/eclipse.jdt.core/wiki
from eclipse.jdt.core.
@stephan-herrmann : regarding structure: I believe it can help if you clone the wiki repo locally to check where the actual wiki files are. Clone https://github.com/eclipse-jdt/eclipse.jdt.core.wiki.git and import the project.
from eclipse.jdt.core.
@stephan-herrmann , for adding links please check the existing ones, e.g. to link a page and a subpage:
[JDT Core Programmer Guide/ECJ/Completion\#Lambda Specifics](ECJ-Completion#Lambda-Specifics "wikilink")
Relative paths to the links don't work for GitHub, or at least I couldn't get them to work. This is painful when using a markdown editor, since the links can't be tested in the editor...
The hierarchy of pages is gone yes, best I could do was to add prefixes to page names. E.g., ECJ-AST
.
Also some of the nicer html formattings from the Eclipse wiki didn't make it through the migration. E.g. some color tags still exist but GitHub doesn't show colors.
from eclipse.jdt.core.
... "painful" describes it well. I thought github wiki was mature software, but a preview speaking a different language from the saved version is ... ("embarrassing"? ...? ).
from eclipse.jdt.core.
I thought github wiki was mature software
During the migration, to me at least the wiki functionality looked more like an afterthought. Overall GitHub doesn't seem to be the best platform for big projects like Eclipse, but not much to do about it at this point.
from eclipse.jdt.core.
embarrassing
Why? It delivers minimum viable product to get people locked & money from organizations that follow the hype. That's how the IT world works since decades. Nothing really embarrassing. Also remember who is the current github owner is and which track of record it has delivering buggy software to customers :-)
from eclipse.jdt.core.
Anything else to discuss here? If not, closing the issue.
from eclipse.jdt.core.
No, I think if we find a new issue we can fix in the wiki itself.
Thanks you Simeon!
from eclipse.jdt.core.
Related Issues (20)
- [21] Add AST rewrite support for new String Template DOM nodes HOT 2
- Unchecked casts go unreported with ECJ HOT 1
- Record pattern matching with `null` gives wrong result HOT 3
- Parameters of compact canonical constructor are not marked as mandated HOT 1
- Error in Java Model (code 980): JDT/Autocomplete wrecked sometimes
- [sealed-classes] Incorrect unused import warning HOT 6
- The operator += is undefined for the argument type(s) CharSequence, String HOT 3
- [21] Enums cause issues in Record Pattern exhaustiveness checks HOT 4
- [21] Record Patterns in InstanceOf not detected HOT 3
- Implementation of javax.lang.model.util.Elements#getTypeElement(String) returns TypeElement with empty metadata HOT 2
- [switch] Switch expression fails with instanceof + ternary operator combo HOT 5
- CCE while typing try-with-resources
- EXPERIMENT: JDT using Javac instead of ECJ HOT 3
- "Error indexing package names!" HOT 4
- The nullness annotation @Nonnull is not applicable for the primitive type byte HOT 1
- Index is not ready on first use
- slow DiagnoseParser.diagnoseParse(boolean) HOT 3
- silent NumberFormatException in SourceMapper
- [Switch][patterns][record] AssertionError at org.eclipse.jdt.internal.compiler.ast.YieldStatement.addSecretYieldResultValue(YieldStatement.java:120) HOT 14
- StackOverflowError in TypeBinding.getQualifiedName(TypeBinding.java:748) HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from eclipse.jdt.core.