references search can't find StackWalker

[iloveeclipse]

references search can't find StackWalker

[iloveeclipse]

@trancexpress : FYI

[iloveeclipse]

https://github.com/eclipse-platform/eclipse.platform.text/blob/b8b0ff5afae1d8a8a2d9a85379adf80afb82030b/org.eclipse.ui.editors/src/org/eclipse/ui/texteditor/MarkerAnnotationPreferences.java#L204

[trancexpress]

Snippet to reproduce with:

public class Test {
	public static void main(String[] args) {
		StackWalker.getInstance().forEach(s -> System.out.println(s));
	}
}

Works with:

Eclipse SDK
Version: 2023-03 (4.27)
Build id: I20221206-1800

Doesn't work with:

Eclipse SDK
Version: 2023-03 (4.27)
Build id: I20230118-1800

Probably one of the recent search fixes broke this.

[trancexpress]

Bisection leads to: 8844381

Reverting the commit on top of current master "fixes" the bug.

So this is a regression from #532.

[iloveeclipse]

Thanks Simeon for bisecting.
@gayanper : could you please check this regression?

[gayanper]

I can have a look at it this weekend. Meanwhile @trancexpress could try with switching off the metaindex ? Then we can be sure that its because of missing information in metaindex rather than a logic issue in the new code.

[trancexpress]

I can have a look at it this weekend. Meanwhile @trancexpress could try with switching off the metaindex ? Then we can be sure that its because of missing information in metaindex rather than a logic issue in the new code.

I assume you mean running Eclipse with -Dorg.eclipse.jdt.disableMetaIndex=true. In that case, yes, the bug is gone with this system property.

[gayanper]

I can have a look at it this weekend. Meanwhile @trancexpress could try with switching off the metaindex ? Then we can be sure that its because of missing information in metaindex rather than a logic issue in the new code.

I assume you mean running Eclipse with -Dorg.eclipse.jdt.disableMetaIndex=true. In that case, yes, the bug is gone with this system property.

Have you also tried reindexing the workspace ?

Because prior to the fix you found, there was a improvement for metaindex to include some missing type information for reference search. That improvement actually increment the index version so that when that change is deployed we should have a workspace reindex happening, may be that didn't worked.

[trancexpress]

Have you also tried reindexing the workspace ?

I'm reproducing the bug with a clean workspace, a new Java project and copy-pasted snippet. There shouldn't be any index to rebuild.

[gayanper]

@testforstephen @iloveeclipse please check the PR and let me know if you find any issues.

[iloveeclipse]

Fixed via #907