Comments (7)
@jarthana please take a look at #635 - As you can see, this issue was created separately to address these failures. There is one omission - thanks for pushing for a relook - have raised #933 to address that.
And here are the details for the rest of the ones:
574719 - 6 - grammar change - this is no longer relevant.
575241 - 3 - already enabled
575356 - 2 - grammar change - Only one test is relevant - that is enabled - other one disabled
575047 - 1 - already enabled
575051 - 1 - not relevant with the fourth preview - hence disabled
578553 - 1 - already enabled
556 - 2 - already enabled
from eclipse.jdt.core.
Here's why I think they are relevant (at least the testBug574719* ones)
The test code now fails with the following compiler error:
A 'default' can occur after 'case' only as a second case label expression and that too only if 'null' precedes in 'case null, default'
This is a new error message that was introduced by the PR I mentioned. Any guess how many tests test this error message?
- Zero.
I think even other tests can be made relevant by adjusting them to test the new behavior. Last resort should be removing them, instead of leaving lot of stale code.
from eclipse.jdt.core.
This is a new error message that was introduced by the PR I mentioned. Any guess how many tests test this error message?
- Zero.
@jarthana - that observation is wrong. Check testIssue_556_003
from eclipse.jdt.core.
@jarthana - that observation is wrong. Check testIssue_556_003
My bad. I didn't account for the escaping. In that case, the tests that are no longer relevant can be removed if you are sure these are covered elsewhere.
from eclipse.jdt.core.
@jarthana - that observation is wrong. Check testIssue_556_003
My bad. I didn't account for the escaping. In that case, the tests that are no longer relevant can be removed if you are sure these are covered elsewhere.
@jarthana Thanks! However, am just holding on to these commented tests until the Switch Pattern is standardized - expected to be in 21 so that if we have some of these becoming relevant again, we can just enable them easily. We can remove them once it is standardized. Please bear with this until then.
from eclipse.jdt.core.
Sure, then let's keep this issue so we can track this. I will remove the milestone.
from eclipse.jdt.core.
I have enabled and fixed some tests and deleted some that are no longer relevant. Closing now.
from eclipse.jdt.core.
Related Issues (20)
- Various tests are failing on master HEAD
- [Sealed Types] Failure to cast an Object to a generic sealed interface type HOT 5
- Generic inferral is not correctly performed when using wildcard HOT 3
- Comparator Errors HOT 3
- [Sealed Types] Strange error from ECJ: Syntax error on token "permits", permits expected HOT 11
- JDT Core throws ClassCastException: NullTypeBinding cannot be cast to class ArrayBinding HOT 4
- Bug 533327 - [9] Implement JEP 211 HOT 2
- ClasspathMultiReleaseJar no longer finds non module-info class files
- Statically importing a class confuses ECJ HOT 1
- Clean build: SourceFile(s) read twice HOT 20
- In some nestings, autocomplete stops working
- ArrayIndexOutOfBoundsException in org.eclipse.jdt.internal.compiler.parser.Scanner.internalScanIdentifierOrKeyword HOT 5
- [Sealed types] ECJ allows a class to be declared as both sealed and non-sealed HOT 4
- Error in JDT Core during AST creation when using exhaustive switch statement and @NotNull HOT 1
- [Sealed types] Disjointness behavior difference vis a vis javac HOT 2
- [Sealed types + switch expression] Internal inconsistency warning at compile time and verify error at runtime HOT 5
- ClasspathTests / JavaModelTests seem to be unstable HOT 1
- [Switch expression + Sealed Types] Suspect diagnostic about switch expression being inexhaustive HOT 2
- [Sealed Types + Enhanced Switch] Incorrect diagnostic about switch not being exhaustive
- Switch pattern matching accepts invalid case HOT 6
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from eclipse.jdt.core.