Regression: call hierarchy has zero results for JARs with module-info

[rdicroce]

Regression: call hierarchy has zero results for JARs with module-info

[iloveeclipse]

@trancexpress : I assume one of our search fixes caused that.

[trancexpress]

Still works in:

Eclipse SDK
Version: 2023-03 (4.27)
Build id: I20230207-1800

Doesn't work in:

Eclipse SDK
Version: 2023-03 (4.27)
Build id: I20230211-0330

First commit I see this with is 241f721, i.e. a regression from the fix for #675.

The matches are filtered here:

 "Worker-7: Fetching children of isExplicitReadOnly" #93 prio=5 os_prio=0 cpu=147.33ms elapsed=481.65s tid=0x00007fdd44003560 nid=0x10f7c runnable  [0x00007fdd882fb000]
   java.lang.Thread.State: RUNNABLE
        at org.eclipse.jdt.internal.core.search.matching.MatchLocator.skipMatch(MatchLocator.java:1281)
        at org.eclipse.jdt.internal.core.search.matching.MatchLocator.locateMatches(MatchLocator.java:1296)
        at org.eclipse.jdt.internal.core.search.matching.MatchLocator.locateMatches(MatchLocator.java:1399)
        at org.eclipse.jdt.internal.core.search.matching.MatchLocator.locateMatches(MatchLocator.java:1541)
        at org.eclipse.jdt.internal.core.search.JavaSearchParticipant.locateMatches(JavaSearchParticipant.java:135)
        at org.eclipse.jdt.internal.core.search.BasicSearchEngine.findMatches(BasicSearchEngine.java:251)
        at org.eclipse.jdt.internal.core.search.BasicSearchEngine.search(BasicSearchEngine.java:602)
        at org.eclipse.jdt.core.search.SearchEngine.search(SearchEngine.java:670)
        at org.eclipse.jdt.internal.corext.callhierarchy.CallerMethodWrapper.findChildren(CallerMethodWrapper.java:155)
        at org.eclipse.jdt.internal.corext.callhierarchy.MethodWrapper.performSearch(MethodWrapper.java:266)
        at org.eclipse.jdt.internal.corext.callhierarchy.MethodWrapper.doFindChildren(MethodWrapper.java:197)
        at org.eclipse.jdt.internal.corext.callhierarchy.MethodWrapper.getCalls(MethodWrapper.java:88)
        at org.eclipse.jdt.internal.ui.callhierarchy.DeferredMethodWrapper.getCalls(DeferredMethodWrapper.java:70)
        at org.eclipse.jdt.internal.ui.callhierarchy.DeferredMethodWrapper.fetchDeferredChildren(DeferredMethodWrapper.java:78)
        at org.eclipse.ui.progress.DeferredTreeContentManager$1.run(DeferredTreeContentManager.java:219)
        at org.eclipse.core.internal.jobs.Worker.run(Worker.java:63)

For whatever reason possibleMatch.getModuleName() returns org.xerial.sqlitejdbc even though the library is not on the module path. As the library is not on the module path, we don't attach module infos (#675) and so lookupEnvironment.getModule(pModuleName) returns null.

[dmatej]

Hmm, that is probably the issue I am experiencing now in 4.28. I am looking forward to 4.29, thank you!