Giter Site home page Giter Site logo

Comments (3)

msujew avatar msujew commented on May 26, 2024 1

@Yokozuna59

The action should also update everywhere the state has been used, shouldn't it?

Yes, it should work similar to the rename LSP feature in that regard.

Do we actually need to override RenameProvider? It's working fine:

It was probably added in error, I don't think it's necessary.

Should we also validate commands uniqueness and usage? Currently, it's possible to have duplicate command names within commands, states, and events.

Yep, that would be good 👍

from langium.

Yokozuna59 avatar Yokozuna59 commented on May 26, 2024

Hi @pluralia,

I plan to work on this if it's possible, but I've few questions:

  1. On the first code actions:

    If a state name doesn't start with a capital letter, replace it with capitalized name (look at the corresponding validation here)

    The action should also update everywhere the state has been used, shouldn't it?

  2. Do we actually need to override RenameProvider? It's working fine:

    Screencast.from.2023-11-04.15-02-12.webm
  3. Should we also validate commands uniqueness and usage? Currently, it's possible to have duplicate command names within commands, states, and events.

from langium.

Yokozuna59 avatar Yokozuna59 commented on May 26, 2024

@msujew Thanks for the feedback. I'm almost done, but the formatting is kind of performing some of the expected behaviors. For example, the following format code:

formatter.keyword('initialState')
    .prepend(Formatting.fit(Formatting.newLine({ allowMore: true }), /* another rule */))
    .append(Formatting.oneSpace());

It formats the previous lines and makes them one, although it has allowMore. If I remove the Formatting.fit, it doesn't do that.

I tried to add and remove another rule in Formatting.fit, but it's performing the same behavior.

from langium.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.