Comments (3)
The action should also update everywhere the state has been used, shouldn't it?
Yes, it should work similar to the rename LSP feature in that regard.
Do we actually need to override RenameProvider? It's working fine:
It was probably added in error, I don't think it's necessary.
Should we also validate commands uniqueness and usage? Currently, it's possible to have duplicate command names within commands, states, and events.
Yep, that would be good 👍
from langium.
Hi @pluralia,
I plan to work on this if it's possible, but I've few questions:
-
On the first code actions:
If a state name doesn't start with a capital letter, replace it with capitalized name (look at the corresponding validation here)
The action should also update everywhere the state has been used, shouldn't it?
-
Do we actually need to override
RenameProvider
? It's working fine:Screencast.from.2023-11-04.15-02-12.webm
-
Should we also validate commands uniqueness and usage? Currently, it's possible to have duplicate command names within commands, states, and events.
from langium.
@msujew Thanks for the feedback. I'm almost done, but the formatting is kind of performing some of the expected behaviors. For example, the following format code:
formatter.keyword('initialState')
.prepend(Formatting.fit(Formatting.newLine({ allowMore: true }), /* another rule */))
.append(Formatting.oneSpace());
It formats the previous lines and makes them one, although it has allowMore
. If I remove the Formatting.fit
, it doesn't do that.
I tried to add and remove another rule in Formatting.fit
, but it's performing the same behavior.
from langium.
Related Issues (20)
- Add features for the Arithmetic example
- Misleading type compatibility validation error
- Enforce isolation of package exports HOT 2
- Parsing EOF leads to invalid CST ranges
- Inconsistent behavior in the completion provider service
- Add service for text document handling HOT 1
- Type hierarchy provider HOT 1
- Testing facilities generated out of the box HOT 1
- Move generator API to separate export HOT 1
- Add read queue to workspace mutex HOT 1
- Non-linear performance during code generation HOT 1
- Add another CompositeGeneratorNode#indent overload HOT 1
- Parse error, but still yields a correct AST HOT 3
- Make the `$container` type more precise in case of guard conditions HOT 2
- Content assist not working at specific grammar element
- Completion Problem due to Parser Error HOT 4
- Parser rule used as type for cross-reference is marked as "unused" HOT 4
- Consecutive keyword not proposed without space HOT 5
- `yo langium` results in `"initialize" is not exported by "node_modules/vscode/extensions.js"` HOT 9
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from langium.