[filesystem] FS protocol

[eclipse-theia]

[filesystem] FS protocol

[svenefftinge]

Let's consider aligning module names too within the context of this task. Currently, we have file-system, fs, and filesystem. Pick one, and use that consistently.

I renamed them to filesystem here TypeFox@102ae1b

[hexa00]

Note however that stats doesn't seem like a replacement to Path even if it could be part of it... I think the object returned by path.parse would be more appropriate and use path.join etc

[kittaakos]

DONE: Let's consider aligning module names too within the context of this task. Currently, we have file-system, fs, and filesystem. Pick one, and use that consistently.

[kittaakos]

We need test coverage for cp too.

[akosyakov]

https://github.com/TypeFox/monaco-languageclient/blob/74bc8038427875ecb5d025821d118d4d9b02c47c/src/diagnostic-collection.ts#L87 should be this.uri.toString() === model.uri.toString() after we got rid of workspace relative paths

[akosyakov]

LSP expects uris, we should consider to use uri instead of path to avoid unnecessary remote calls to get an uri for a path, e.g. in the case of file events

[svenefftinge]

vscode's IFileSystem looks like a pretty close match to what we want to have https://github.com/Microsoft/vscode/blob/master/src/vs/platform/files/common/files.ts

[svenefftinge]

Maybe we should use https://medialize.github.io/URI.js/docs.html instead of monaco's uri.
It supports things like resolving relative uris against absolute once.

[svenefftinge]

That said, in the protocol we should use plain strings and put the uri-part into the parameter names.
I.e. resource: URI would become uri: string

[kittaakos]

The current FS API work is being done on the fs_redesign branch. The changes can be reviewed here.

[svenefftinge]

I merged the branch. Follow-up issues should be filed separately