Giter Site home page Giter Site logo

Comments (6)

vietj avatar vietj commented on May 30, 2024 1

I believe we should start to provide different examples when the code is started from a non vertx thread, e.g.

vertx.deployVerticle(...).await();

would make sense to me

  • it forces the main thread to await the success or failure of the deployment
  • it will allow event-loop to be started and prevent the exit

However await() currently is only supported on worker threads, but it would make sense to support it from a non vertx event-loop thread.

from vert.x.

tsegismont avatar tsegismont commented on May 30, 2024

Quick analysis: when the virtual thread model is used, no event loop is created before the http server is started. Vert.x threads are non-daemon by default, and they prevent the JVM from shutting down.

In the sample before, the application reaches the end of the main method before the virtual thread triggers the creation of the http server.

That is why the JVM shut downs early.

from vert.x.

tsegismont avatar tsegismont commented on May 30, 2024

cc @vietj

Many applications rely on the fact that the JVM will stay alive even after the main thread reaches the end of the method.

from vert.x.

vietj avatar vietj commented on May 30, 2024

yeah I found this issue too a while ago, I don't know yet what is the best way to address it.

I believe that applications should not rely on vertx though

from vert.x.

tsegismont avatar tsegismont commented on May 30, 2024

I just found that this (funny?) behavior:

vertx.deployVerticle(new MainVerticle(), deploymentOptions)

to:

vertx.deployVerticle(MainVerticle.class.getName(), deploymentOptions)

Then the JVM doesn't stop because Vert.x starts an event loop

I believe that applications should not rely on vertx though

I understand. On the other hand, we have so many examples which look like the example in the description.

from vert.x.

tsegismont avatar tsegismont commented on May 30, 2024

Perhaps we can find the difference between deploying a verticle with a class name or with a class or an instance, and make sure it always works like deploying using a class name.

from vert.x.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.