Giter Site home page Giter Site logo

Comments (5)

BoykoAlex avatar BoykoAlex commented on September 27, 2024

@martinlippert asked me to look into this issue... Don't think I have a good idea how to fix it... I've created a hack to listen to MarkerAnnotationModel changes on MarkerResoltionQuickAssistProcessor from generic editor and if the changed marker annotation is one of those for which resolutions are currently shown then I'd execute quick assist op on the current editor.... it worked but this solution has plenty of "weak links"

  1. The marker is indeed changed once resolutions (code actions) are fetched from the LS, however this doesn't result in annotation model change since marker positions is unchanged - hacked eclipse editors plugin to send the event anyway
  2. Not sure how can i tell if the pop up with proposals is gobe or still up when i receive the annotation model change event in MarkerResoltionQuickAssistProcessor

If @mickaelistria or @martinlippert had any ideas or plans for this issue please share :-)

from lsp4e.

mickaelistria avatar mickaelistria commented on September 27, 2024

Is the main issue for hover or for Ctrl+1 ?

from lsp4e.

BoykoAlex avatar BoykoAlex commented on September 27, 2024

Both are having the issue but I think Ctrl-1 is the only case I've been trying to fix...

from lsp4e.

mickaelistria avatar mickaelistria commented on September 27, 2024

It seems a bit tricky to navigate from the LSPCodeActionQuickAssistProcessor to the dialog that is used to render them. However, maybe it's possible to just get current shell, close it if we see it's a table that contains the "Computing..." element and then programatically re-trigger the QuickAssist?

from lsp4e.

BoykoAlex avatar BoykoAlex commented on September 27, 2024

@mickaelistria attached a draft PR for the review. Addresses quick assist popup and hover. Seems to work :-)

from lsp4e.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.