Comments (5)
@martinlippert asked me to look into this issue... Don't think I have a good idea how to fix it... I've created a hack to listen to MarkerAnnotationModel changes on MarkerResoltionQuickAssistProcessor
from generic editor and if the changed marker annotation is one of those for which resolutions are currently shown then I'd execute quick assist op on the current editor.... it worked but this solution has plenty of "weak links"
- The marker is indeed changed once resolutions (code actions) are fetched from the LS, however this doesn't result in annotation model change since marker positions is unchanged - hacked eclipse editors plugin to send the event anyway
- Not sure how can i tell if the pop up with proposals is gobe or still up when i receive the annotation model change event in
MarkerResoltionQuickAssistProcessor
If @mickaelistria or @martinlippert had any ideas or plans for this issue please share :-)
from lsp4e.
Is the main issue for hover or for Ctrl+1 ?
from lsp4e.
Both are having the issue but I think Ctrl-1 is the only case I've been trying to fix...
from lsp4e.
It seems a bit tricky to navigate from the LSPCodeActionQuickAssistProcessor to the dialog that is used to render them. However, maybe it's possible to just get current shell, close it if we see it's a table that contains the "Computing..." element and then programatically re-trigger the QuickAssist?
from lsp4e.
@mickaelistria attached a draft PR for the review. Addresses quick assist popup and hover. Seems to work :-)
from lsp4e.
Related Issues (20)
- Exception in LSPEclipseUtils.applyEdits
- Master build broken due to failed unit test HOT 6
- Performance issue when formatting a large file
- Folding annotations gets removed on large files while editing
- SimRel Participation? HOT 13
- MicroProfileGenerateOpenAPIOperation code action breaks developer workflow HOT 1
- Add References to editor context menu HOT 3
- Support partial results for DocumentSymbol
- Add ID to menu to allow external contributions
- CTRL+SHIFT+T conflict HOT 4
- Remove end slash from rootPath / rootUri / workspaceFolders
- Semantic Tokens support HOT 3
- Open Declaration (Ctrl + Click / F3) does not collect declarations
- Hovering over Maven elements perhaps needs longer timeout
- The default label for multiple declarations is not useful HOT 11
- LSPEclipseUtils.FILE_URI should be 'file:' instead of 'file://' HOT 2
- Inline type hints are missing spacing
- Spurious error "Marker id 15074644 not found" HOT 2
- "[Info] ESLint server running in node v18.18.2" keeps showing up in logs HOT 2
- Could not get trigger characters due to timeout after 50 milliseconds HOT 4
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from lsp4e.