Giter Site home page Giter Site logo

Comments (4)

pilhuhn avatar pilhuhn commented on August 22, 2024

I see the inconsistency and you are right.
I guess the solution is a bit more complex, as e.g Prometheus expects seconds in the exposed metric names.
I will make the names of the constants consistent.

from microprofile-metrics.

keilw avatar keilw commented on August 22, 2024

Similar to Parfait it would of course be possible to simply use the CLDR module and get conversion on the Java level for free. If enums are preferred, it would work in the way https://github.com/unitsofmeasurement/uom-impl-enum did it, but an "Uber-enum" for all types of quantities does not work because it cannot implement multiple quantity types at the same time. I can propose a PR for that although the project here still looks more or less at a design level, no real API yet.

from microprofile-metrics.

keilw avatar keilw commented on August 22, 2024

Actually if only the Unit part is required (AFAIR Parfait so far doesn't use more than that either) then it boils down to enums like those in the https://github.com/unitsofmeasurement/uom-impl-enum/tree/master/src/main/java/tec/uom/impl/enums/unit package.

from microprofile-metrics.

keilw avatar keilw commented on August 22, 2024

I think this can be closed, looks like the MetricUnit, formerly MpMUnit has only singular constants now.

from microprofile-metrics.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.