Comments (4)
I see the inconsistency and you are right.
I guess the solution is a bit more complex, as e.g Prometheus expects seconds in the exposed metric names.
I will make the names of the constants consistent.
from microprofile-metrics.
Similar to Parfait it would of course be possible to simply use the CLDR module and get conversion on the Java level for free. If enums are preferred, it would work in the way https://github.com/unitsofmeasurement/uom-impl-enum did it, but an "Uber-enum" for all types of quantities does not work because it cannot implement multiple quantity types at the same time. I can propose a PR for that although the project here still looks more or less at a design level, no real API yet.
from microprofile-metrics.
Actually if only the Unit
part is required (AFAIR Parfait so far doesn't use more than that either) then it boils down to enums like those in the https://github.com/unitsofmeasurement/uom-impl-enum/tree/master/src/main/java/tec/uom/impl/enums/unit package.
from microprofile-metrics.
I think this can be closed, looks like the MetricUnit
, formerly MpMUnit
has only singular constants now.
from microprofile-metrics.
Related Issues (20)
- [Potential] Re-instate @RegistryType and MetricRegistry.Type, but as deprecated instead. HOT 1
- Update to use MicroProfile Parent 3.0
- `@RegistryScope` should be a qualifier HOT 3
- Consider clarifying what period of time the JAX-RS metrics measure and assumptions about timeliness of metrics updates
- Outdated dependency versions HOT 12
- Open Liberty 22.0.0.13-beta: MicroProfile Metrics 5.0 Compatible Certification Request
- ensure MP Starter works with MP Metrics 5 HOT 1
- Address the redundancy of units for the Timer metric HOT 1
- The `@Timed` annotation defaults to SECONDS when it should be NANOSECONDS.
- Errors in MicroProfile 6.0 javadoc generation HOT 4
- requirement to have consistent tag sets causes problems for multi-app app server implementations
- Clarify naming convention when `@Metric` applies to a parameter
- Clarify: Which annotations can be used on private methods? HOT 1
- Add JPMS module-info.java
- Create spec for MP Metrics 5.1 HOT 1
- Consider changing TCK tests so they do not interfere with each other or rely on ordering
- Update to use the mp-parent 3.2
- Fix optional Base Metrics TCK test where `gc.time` is checked as a counter when it should be gauge. HOT 1
- Open Liberty 22.0.0.10-beta: MicroProfile Metrics 5.1 Compatible Certification Request
- build error when doclint checks are enabled
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from microprofile-metrics.