version coherence with eccodes

[ecmwf]

version coherence with eccodes

[shahramn]

You need the latest ecCodes i.e. v2.14.0 https://confluence.ecmwf.int/display/ECC/ecCodes+version+2.14.0+released Apologies for not having made it clear

…

________________________________ From: Kai Mühlbauer <[email protected]> Sent: 07 October 2019 08:10 To: ecmwf/eccodes-python <[email protected]> Cc: Subscribed <[email protected]> Subject: [ecmwf/eccodes-python] version coherence with eccodes (#9) Trying to create bindings for ecCodes 2.13.1 using eccodes-python 0.9.3 breaks due to gribapi/_bindings.c:5679:12: error: 'GRIB_FUNCTIONALITY_NOT_ENABLED' undeclared How does one know which version of ecCodes the eccodes-python packages needs? — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub<#9?email_source=notifications&email_token=AF4HFU4AVO6G63KTKIEIMW3QNLOETA5CNFSM4I6ARX3KYY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4HP7JTSA>, or mute the thread<https://github.com/notifications/unsubscribe-auth/AF4HFUZMRZKOCCN4O25YK2TQNLOETANCNFSM4I6ARX3A>.

[kmuehlbauer]

@shahramn No worries. But how should running into this sort of error be prevented?

If the user installs some ecCodes version and then pip install eccodes-python this can break if the correct ecCodes version is not available.

Would it be possible to check for the needed version of ecCodes and issue a warning/error with additional guidelines?

[alexamici]

@shahramn the version check that you added here:

eccodes-python/gribapi/__init__.py

Line 5 in a896f60

# The minimum required version for the ecCodes package

looks way too strict. The failure reporte in this issue happen only when you try to build the bindings, but by raising and exception it is not possible to use eccodes-python even with the ABI, that is what most of current users do.

At the moment for example the whole cfgrib test suite would pass with version 2.12.0 if it were not for this check.

Can you change the raise to a simple print, please?