Giter Site home page Giter Site logo

Comments (4)

WeiqunZhang avatar WeiqunZhang commented on August 19, 2024

I don't think it will break anything. The users are not required to use the new warpx.prob_lo etc. If they don't, there are no changes in behaviors. We could make warpx.* required if that's desired.

from warpx.

RemiLehe avatar RemiLehe commented on August 19, 2024

Still, it will break things like num_particles_per_cell_each_dim which will now always expect 3 numbers, even in 2D

from warpx.

WeiqunZhang avatar WeiqunZhang commented on August 19, 2024

Well, it's easy to maintain backward compatibility for num_particles_per_cell_each_dim.

    num_particles_per_cell_each_dim.clear();
    pp.getarr("num_particles_per_cell_each_dim", num_particles_per_cell_each_dim);
#if (AMREX_SPACEDIM == 2)
    if (num_particles_per_cell_each_dim.size() == 2) {
        num_particles_per_cell_each_dim.resize(3);
        num_particles_per_cell_each_dim[2] = num_particles_per_cell_each_dim[1];
        num_particles_per_cell_each_dim[1] = 1;
    }
#endif

Yes, PlasmaInjector does need to be modified for 2d. But that's case independent of ParmParse.

from warpx.

RemiLehe avatar RemiLehe commented on August 19, 2024

OK, sounds good. Thanks for the above code suggestion.

from warpx.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.