Comments (4)
I don't think it will break anything. The users are not required to use the new warpx.prob_lo
etc. If they don't, there are no changes in behaviors. We could make warpx.*
required if that's desired.
from warpx.
Still, it will break things like num_particles_per_cell_each_dim
which will now always expect 3 numbers, even in 2D
from warpx.
Well, it's easy to maintain backward compatibility for num_particles_per_cell_each_dim
.
num_particles_per_cell_each_dim.clear();
pp.getarr("num_particles_per_cell_each_dim", num_particles_per_cell_each_dim);
#if (AMREX_SPACEDIM == 2)
if (num_particles_per_cell_each_dim.size() == 2) {
num_particles_per_cell_each_dim.resize(3);
num_particles_per_cell_each_dim[2] = num_particles_per_cell_each_dim[1];
num_particles_per_cell_each_dim[1] = 1;
}
#endif
Yes, PlasmaInjector does need to be modified for 2d. But that's case independent of ParmParse.
from warpx.
OK, sounds good. Thanks for the above code suggestion.
from warpx.
Related Issues (20)
- Managed Memory Leftovers: MR Init, QED, Ionization HOT 4
- Inhomogeneous Neumann on EB? HOT 1
- PEC boundaries: Copy values in guard cells HOT 2
- Please delete the issue HOT 1
- Classical in-situ radiation computation HOT 7
- Laser envelope model HOT 1
- Make `add initial fields on grid` work for RZ HOT 2
- Legacy TXYE files no longer supported HOT 3
- Remove Harris laser?
- WarpX on new HPC cluster at UCI HOT 48
- Alternative method of particle initialisation from a file HOT 4
- hdf5 files HOT 22
- Spectral solver with PML Boundaries and moving window HOT 3
- running on multiGPU machine HOT 44
- Problem of checkpoint and restart HOT 3
- 1D laser behavior not understood HOT 3
- Singularity Images HOT 3
- Creating a `WarpX` Profile for the Karolina HPC System HOT 3
- Laser does not move when using "parse_field_function" HOT 1
- AnalyticDistribution HOT 6
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from warpx.