Do not use `except Exception`

[ecsim]

Do not use `except Exception`

[katyhuff]

@sepandhaghighi : I agree with @nnadeau . This is very bad practice and should be strongly reconsidered or given a reason.

[sepandhaghighi]

Hi @nnadeau

It's true, using of general exception is not a good point but in OPEM we don't want to handle different exceptions in different ways so I think it's okay.

Thanks

[sepandhaghighi]

@katyhuff

As I mentioned before, in OPEM we don't want to handle different exceptions in different ways, and there is a single response to all of exceptions so I think general exception is not a problem in this case.

Thanks

[engnadeau]

@sepandhaghighi, unfortunately I disagree. The vast majority of the package's functions have a try-except at their returns, catching everything and anything, even for functions that are simply multiplying several floats...

E.g.,

opem/opem/Static/Amphlett.py

Lines 11 to 25 in d9748c6

	def Power_Thermal_Calc(VStack,N,i):
	'''
	This function calculate thermal power
	:param VStack: VStack [V]
	:type VStack : float
	:param N: number of single cells
	:type N : int
	:param i: Cell load current [A]
	:type i : float
	:return: Thermal power [W]
	'''
	try:
	return i*((N*Eth)-VStack)
	except Exception:
	return None

The function is a simple/trivial: float * ((int * const float) - float)

There should literally never be an exception...

[sepandhaghighi]

@nnadeau
These functions run in a cascade mode and if prev function return None this exception raised.
Type of exception is not important for us
For example if VStack =None from previous calculation.