Simple way to skip image in namespace

[edannenberg]

Simple way to skip image in namespace

[edannenberg]

build now supports a repeatable --exclude arg

[edannenberg]

There is indeed an undocumented EXCLUDE env. This will also allow you to quite easily shoot yourself in the foot by skipping images that are required for building other images, though for your case it should be perfectly fine:

$ EXCLUDE=gentoobb/{cadvisor,foo} ./build.sh build gentoobb

Should do the trick, can't remember having ever used it myself though, let me know if it doesn't work. :p

I will leave this open for the upcoming documentation rewrite.

[berney]

OK great, I thought there might be a proper way I had missed.

I renamed .cadvisor back to cadvisor and I tried EXCLUDE=gentoobb/{cadvisor,foo} ./build.sh build gentoobb and it still tries to build cadvisor, if I just do EXCLUDE=gentoobb/cadvisor ./build.sh build gentoobb it lists cadvisor but no build is attempted.

I also tried EXCLUDE=(gentoobb/{cadvisor,foo}) ./build.sh build gentoobb so that EXCLUDE is a BASH Array but it also tries to build cadvisor. I think the array is working fine: -

$ EXCLUDE=(gentoobb/{cadvisor,foo})
$ for x in ${EXCLUDE[@]}; do echo $x; done
gentoobb/cadvisor
gentoobb/foo

My BASH foo isn't the greatest so I don't understand how the code you linked to works. Could it have a bug or am I doing something wrong? So far I've only needed to skip one image and I have a work-around if I need to skip many.

OH I just worked it out, its because IFS=', '. EXCLUDE=gentoobb/cadvisor,gentoobb/foo ./build.sh build gentoobb works, skips cadvisor. EXCLUDE=(gentoobb/cadvisor,gentoobb/foo) ./build.sh build gentoobbdoesn't work, it tries to build cadvisor.

I don't think it's a big deal, but maybe the code can be updated so that gentoobb/{foo,bar} style can be used.

[edannenberg]

Yea, as I said, I haven't use this since it's implementation. 😛 Took a closer look and braces expansion is sadly a bit special and doesn't work with variables. So EXCLUDE would have to be implemented as script param instead of env for this to work. build.sh -n build gentoobb/{foo,baz} does work for example.