Hoop jumping for commit process

[edbrsk]

Hoop jumping for commit process

[peterennis]

Use all lower case and push again:

VS Code does not like being pushed 😢

[peterennis]

Just do it with tortoisegit

git.exe push --progress "origin" One:One

husky > pre-push (node v10.15.1)

> [email protected] lint C:\ae\adaept.com\d3-stencil
> npx tslint --project tsconfig.json --fix


> [email protected] circular C:\ae\adaept.com\d3-stencil
> npx madge -c --extensions ts ./src --ts-config ./tsconfig.json

- Finding files=============

WARNING: You are currently running a version of TypeScript which is not officially supported by typescript-estree.

You may find that it works just fine, or you may not.

SUPPORTED TYPESCRIPT VERSIONS: >=3.2.1 <3.4.0

YOUR TYPESCRIPT VERSION: 3.4.5

Please only submit bug reports when using the officially supported version.

=============
\ ./components.d.ts| interfaces/index.ts/ interfaces/graph.ts- interfaces/graph-data.ts\ interfaces\data-types/index.ts| interfaces\options-types/index.ts/ interfaces\options-types/axis.ts- interfaces\formats/index.ts\ interfaces\charts-options/index.ts| interfaces\charts-options/pie-chart.ts/ interfaces\charts-options/bar-chart.ts- interfaces\charts-options/line-chart.ts\ interfaces\charts-options/bcg-matrix-chart.ts| interfaces/graph-meta.ts/ interfaces/legend-data.ts- decorators/index.ts\ decorators/resize.ts| ./index.d.ts/ shared/default-graph-data.ts- utils/index.ts\ utils/formats.ts| utils/formatter.ts/ utils/has-data.ts- shared/index.ts\ utils\tests/circular-find.spec.ts| utils\tests/currency-formatter.spec.ts/ utils\tests/formatter.spec.ts- utils\tests/has-data.spec.tsProcessed 39 files (648ms)

√ No circular dependency found!


> [email protected] test C:\ae\adaept.com\d3-stencil
> stencil test --spec --e2e --coverage

m[56:10.9]  @stencil/core v1.0.0-beta.2 

m[ WARN  ]  This is a prerelease build, undocumented changes might happen
at any time. Technical support is not available for prereleases, but
any assistance testing is appreciated.

m[56:11.0]  testing e2e and spec files
m[56:11.0]  build, d3-stencil, dev mode, started ...
m[56:11.1]  transpile started ...
m[56:13.2]  transpile finished in 2.03 s
m[56:13.2]  generate styles started ...
m[56:13.2]  bundling components started ...
m[56:13.5]  generate styles finished in 306 ms
m[56:14.9]  bundling components finished in 1.65 s
m[56:15.1]  build finished in 4.18 s

PASS src/utils/tests/circular-find.spec.ts
PASS src/utils/tests/currency-formatter.spec.ts
PASS src/utils/tests/formatter.spec.ts
PASS src/utils/tests/has-data.spec.ts
-----------------------|----------|----------|----------|----------|-------------------|
File                   |  % Stmts | % Branch |  % Funcs |  % Lines | Uncovered Line #s |
-----------------------|----------|----------|----------|----------|-------------------|
All files              |    49.06 |    30.91 |     62.5 |       50 |                   |
circular-find.ts      |      100 |      100 |      100 |      100 |                   |
currency-formatter.ts |      100 |      100 |      100 |      100 |                   |
formats.ts            |      100 |      100 |      100 |      100 |                   |
formatter.ts          |      100 |      100 |      100 |      100 |                   |
has-data.ts           |      100 |      100 |      100 |      100 |                   |
index.ts              |      100 |      100 |      100 |      100 |                   |
init-slots.ts         |    16.67 |        0 |        0 |    16.67 |... 23,28,29,30,33 |
object-assign-deep.ts |     2.22 |        0 |        0 |     2.33 |... 3,86,91,97,101 |
-----------------------|----------|----------|----------|----------|-------------------|

Test Suites: 4 passed, 4 total
Tests:       20 passed, 20 total
Snapshots:   0 total
Time:        3.855s
Ran all test suites.

Enumerating objects: 7, done.
Counting objects: 100% (7/7), done.
Delta compression using up to 8 threads
Compressing objects: 100% (4/4), done.
Writing objects: 100% (4/4), 15.04 KiB | 3.01 MiB/s, done.
Total 4 (delta 3), reused 0 (delta 0)
remote: Resolving deltas: 100% (3/3), completed with 3 local objects.
remote:
remote: Create a pull request for 'One' on GitHub by visiting:
remote:      https://github.com/peterennis/d3-stencil/pull/new/One
remote:
To https://github.com/peterennis/d3-stencil
* [new branch]      One -> One

Success (21688 ms @ 5/20/2019 11:56:23 AM)

Hello @peterennis

What do you suggest here? 😉

Thanks!

[peterennis]

@edgarordonez

1. Husky barking is more of a documentation issue for PRs.
   Deal with it later once the doc project is going.
2. More tests for better coverage.
   Deal with it when Stencil One is final.

[peterennis]

Fixed with this PR: #43