Giter Site home page Giter Site logo

Comments (5)

eddelbuettel avatar eddelbuettel commented on May 30, 2024

There is no such thing as 'Ropen' (as it is just called 'R' nomatter what Microsoft calls it), and the compiler warning is for a contributed file needed only on Windows.

from rcppannoy.

SamGG avatar SamGG commented on May 30, 2024

Thanks for your reply. What is worrying me is that if the bit width of off and maxsize is 32, then the right shifting results in zero. So I feel uncomfortable about such a thing in the code. Let me know.

from rcppannoy.

eddelbuettel avatar eddelbuettel commented on May 30, 2024

It's just for mmap() i.e. serialization to/from a file. Maybe you want to contribute a unit test validating that a round trip works -- or conversely, demonstrate that something is amiss?

from rcppannoy.

SamGG avatar SamGG commented on May 30, 2024

Thanks for your kind reply and proposal. I am already contributing to other repos, but I would have contribute here if you told me this warning is worrying.

from rcppannoy.

eddelbuettel avatar eddelbuettel commented on May 30, 2024

I am in parts with you. I also hate compiler warning. But I don't see this one :) Linux has a proper mmap(), you are seeing a warning available on Windows.

from rcppannoy.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.