You can create a custom search with an empty name, which is then impossible to delete without external tools

[LikeLakers2]

You can create a custom search with an empty name, which is then impossible to delete without external tools

[klightspeed]

With the "blank name", I'm guessing this is specifically when you have scans (the wireframe sphere) selected, as the save button won't do anything for the stars search if you have not performed a search yet.

EDDiscovery/EDDiscovery/UserControls/Search/SearchScans.cs

Lines 177 to 193 in 341c0f0

	private void extButtonSave_Click(object sender, EventArgs e)
	{
	BaseUtils.ConditionLists cond = Valid();
	if (cond != null)
	{
	string name = ExtendedControls.PromptSingleLine.ShowDialog(this.FindForm(), "Name:".T(EDTx.SearchScans_Name), "", "Enter Search Name:".T(EDTx.SearchScans_SN), this.FindForm().Icon);
	if (name != null)
	{
	HistoryListQueries.Instance.Set(name, cond.ToString(), HistoryListQueries.QueryType.User);
	HistoryListQueries.Instance.SaveUserQueries();
	UpdateComboBoxSearches();
	comboBoxSearches.SelectedIndexChanged -= ComboBoxSearches_SelectedIndexChanged;
	comboBoxSearches.SelectedItem = name;
	comboBoxSearches.SelectedIndexChanged += ComboBoxSearches_SelectedIndexChanged;
	}
	}
	}

                if (name != null)

should probably be

                if (!string.IsNullOrWhiteSpace(name))

[Eahlstan]

if (!string.IsNullOrWhitespace(name))

I dislike that, I got a few whitespace searches to show bodies on the Surveyor without expanding everything with the search names.

[Eahlstan]

And in this case it's really null (and not a whitespace), so the null check either fails or isn't active when saving the search:

    {
      "Name":"",
      "Condition":"Level == 4",
      "SortCondition":"",
      "SortAscending":false
    }

[robbyxp1]

HasChars()

[Eahlstan]

HasChars()

I like that, it doesn't let me save an empty name, but whitespace names work.

Thought: Empty name doesn't throw an error message, it would be good if it does.

[LikeLakers2]

[@klightspeed] With the "blank name", I'm guessing this is specifically when you have scans (the wireframe sphere) selected [...]

Yes, that's right. Sorry for not specifying - I forgot that scans weren't the only thing you can search, as I'm not only new-ish to EDDiscovery, but the vast majority of my usage of the Search panel has been to search my scans.