share via sms?

[eddyverbruggen]

share via sms?

[EddyVerbruggen]

Hi,

Great idea!

I have just checked this in for iOS and Android. I was not able to test it thoroughly on Android, but it seems to work fine. I hope you can test it a bit...

Thanks,
Eddy

[razwasserstein]

Hi,
Wow! Do you mean you did the change?
Is it updated in phonegap build?

thanks!
Doron

[EddyVerbruggen]

It's pending review at build.phonegap.com. I'll let you know when it's approved. It's version 3.8.2 which includes the shareViaSMS feature.

[razwasserstein]

Wow!!
Thank you very much!!

I didn't expect you to do it so fast!
Thanks,
Doron

2014-02-11 9:28 GMT+02:00 Eddy Verbruggen [email protected]:

It's pending review at build.phonegap.com. I'll let you know when it's
approved. It's version 3.8.2 which includes the shareViaSMS feature.

Reply to this email directly or view it on GitHubhttps://github.com//issues/44#issuecomment-34731757
.

[razwasserstein]

Hi,
I see the issue is closed, but if I may, I wanted to suggest something else - what do you think about a paramterer for prefilling the numbers (in the sms dialog)?

Doron.

[EddyVerbruggen]

Hi,

Could do that indeed, but there is also an sms plugin for build.phonegap.com which u can use.

On 11 feb. 2014, at 10:49, razwasserstein [email protected] wrote:

Hi,
I see the issue is closed, but if I may, I wanted to suggest something else - what do you think about a paramtere for prefilling the numbers (in the sms dialog)?

Doron.

—
Reply to this email directly or view it on GitHub.

[razwasserstein]

Hi,
Thank you for your quick response!
The problem with that plugin is that it is not compatible with phonegap
3+.. For months, and nobody answers the issues there..
So, we are looking for alternatives.. Your plugin is really nice, and it
works like a charm. If there was a possibility to add the numbers it would
be super awsome!

Thanks again!
Doron
בתאריך 11 בפבר 2014 12:10, "Eddy Verbruggen" [email protected] כתב:

Hi,

Could do that indeed, but there is also an sms plugin for
build.phonegap.com which u can use.

On 11 feb. 2014, at 10:49, razwasserstein [email protected]
wrote:

Hi,
I see the issue is closed, but if I may, I wanted to suggest something
else - what do you think about a paramtere for prefilling the numbers (in
the sms dialog)?

Doron.

—
Reply to this email directly or view it on GitHub.

—
Reply to this email directly or view it on GitHubhttps://github.com//issues/44#issuecomment-34740884
.

[EddyVerbruggen]

Hi,

It would be a simple addition... so reopening and I will probably get to it soon.

[EddyVerbruggen]

Hi again,

I've added the (optional) phonenumbers param (you can pass a comma separated list of phonenumbers). Tested on iOS7 and Android 4.4, but I'm quite sure any lower version supports it just as well.

Look out for v3.8.3 to be supported at build.phonegap.com

Thx for the feature request,
Eddy

[razwasserstein]

Hi Eddy!
Thank you very much!
You really helped us with this.
I have a question for you: we want to do a camera plugin with a
freelancer.. Do you think you might be intrested?

Doron
בתאריך 12 בפבר 2014 23:26, "Eddy Verbruggen" [email protected] כתב:

Hi again,

I've added the (optional) phonenumbers param (you can pass a comma
separated list of phonenumbers). Tested on iOS7 and Android 4.4, but I'm
quite sure any lower version supports it just as well.

Look out for v3.8.3 to be supported at build.phonegap.com

Thx for the feature request,
Eddy

—
Reply to this email directly or view it on GitHubhttps://github.com//issues/44#issuecomment-34919724
.

[razwasserstein]

Hi Eddy,

We want to use your social-share plugin, but we encountered something
wierd.. we wanted to ask you if you are familiar with this.

When we tried to share the link: www.remini.me/remini?i=1111 with whatsapp
on IOS, sometimes the text inserted to whatsapp is: "(null)", or simply
empty string.
We tried to play with it a little bit, and we saw that when there is
question mark (?), it seems not to work..
But on android everything works great.. Do you know this behaviour?

Thanks in advance,
Doron

2014-02-12 23:51 GMT+02:00 Doron Oded [email protected]:

Hi Eddy!
Thank you very much!
You really helped us with this.
I have a question for you: we want to do a camera plugin with a
freelancer.. Do you think you might be intrested?

Doron
בתאריך 12 בפבר 2014 23:26, "Eddy Verbruggen" [email protected]
כתב:

Hi again,

I've added the (optional) phonenumbers param (you can pass a comma
separated list of phonenumbers). Tested on iOS7 and Android 4.4, but I'm
quite sure any lower version supports it just as well.

Look out for v3.8.3 to be supported at build.phonegap.com

Thx for the feature request,
Eddy

—
Reply to this email directly or view it on GitHubhttps://github.com//issues/44#issuecomment-34919724
.

[razwasserstein]

Hi Eddy,

We played with it a little more, and we think the "=" (equal mark) is the
cause of the problem..
Do you know this problem? Is there some workaround? Is it fixable?

Thanks again,
Doron

2014-02-23 18:27 GMT+02:00 Doron Oded [email protected]:

Hi Eddy,

We want to use your social-share plugin, but we encountered something
wierd.. we wanted to ask you if you are familiar with this.

When we tried to share the link: www.remini.me/remini?i=1111 with
whatsapp on IOS, sometimes the text inserted to whatsapp is: "(null)", or
simply empty string.
We tried to play with it a little bit, and we saw that when there is
question mark (?), it seems not to work..
But on android everything works great.. Do you know this behaviour?

Thanks in advance,
Doron

2014-02-12 23:51 GMT+02:00 Doron Oded [email protected]:

Hi Eddy!
Thank you very much!
You really helped us with this.
I have a question for you: we want to do a camera plugin with a
freelancer.. Do you think you might be intrested?

Doron
בתאריך 12 בפבר 2014 23:26, "Eddy Verbruggen" [email protected]
כתב:

Hi again,

I've added the (optional) phonenumbers param (you can pass a comma
separated list of phonenumbers). Tested on iOS7 and Android 4.4, but I'm
quite sure any lower version supports it just as well.

Look out for v3.8.3 to be supported at build.phonegap.com

Thx for the feature request,
Eddy

—
Reply to this email directly or view it on GitHubhttps://github.com//issues/44#issuecomment-34919724
.

[EddyVerbruggen]

Hi, I'll take a good look in about an hour.

[EddyVerbruggen]

Hi @razwasserstein, thanks for pinning this down to the "=" character. You are right, it was a problem on iOS only, because WhatsApp is started via this URL scheme: whatsapp://send?text=[your text]

When [your text] contained a "=", the 'text' param of the URL couldn't be parsed correctly by WhatsApp.

It's fixed now, in case you installed the plugin manually you only need to replace SocialSharing.m

[razwasserstein]

Hi Eddy,

Thank you!
Did you update the phongap build version?

Doron.
בתאריך 23 בפבר 2014 21:17, "Eddy Verbruggen" [email protected] כתב:

Hi @razwasserstein https://github.com/razwasserstein, thanks for
pinning this down to the "=" character. You are right, it was a problem on
iOS only, because WhatsApp is started via this URL scheme:
whatsapp://send?text=[your text]

When [your text] contained a "=", the 'text' param of the URL couldn't be
parsed correctly by WhatsApp.

It's fixed now, in case you installed the plugin manually you only need to
replace SocialSharing.m

—
Reply to this email directly or view it on GitHubhttps://github.com//issues/44#issuecomment-35840014
.

[EddyVerbruggen]

It is pending review at Phonegap Build, it's the 4.0.1 version you'll want to use. I hope they review and approve it soon.

[razwasserstein]

Hi Eddy,

Sorry for bothering you all the time :)
I think I've found another small issue with the shareViaSMS function.. When
we activate it with text and numbers, the native sms screen appears, but
twice..
I mean - the native SMS screen appears, we click 'SEND', and then we click
on the "back button", and another SMS screen appears like the first one -
as if we called the plugin twice.. only we didn't..

Again I'm sorry for bothering you..
Is there a chance you can take a look?

Thanks,
Doron

2014-02-23 21:55 GMT+02:00 Eddy Verbruggen [email protected]:

It is pending review at Phonegap Build, it's the 4.0.1 version you'll want
to use. I hope they review and approve it soon.

Reply to this email directly or view it on GitHubhttps://github.com//issues/44#issuecomment-35841225
.

[EddyVerbruggen]

Hi Doron, no worries, thanks for letting me know!
I guess you see this behaviour on Android? On which device and OS version does this happen?

Thanks for the help!
Eddy

[razwasserstein]

Hi,

Thank you for your super-fast response.
Yes, on Android 4.0.3, Galaxy S2.

Thank you!
Doron

2014-02-27 20:33 GMT+02:00 Eddy Verbruggen [email protected]:

Hi Doron, no worries, thanks for letting me know!
I guess you see this behaviour on Android? On which device and OS version
does this happen?

Thanks for the help!
Eddy

Reply to this email directly or view it on GitHubhttps://github.com//issues/44#issuecomment-36274702
.

[EddyVerbruggen]

Hi, I have an S2 at my office. I'll check it tomorrow.
Can you in the meanwhile confirm this issue on a newer device? No worries if you can't.

[razwasserstein]

Hi Eddy,

I checked it on galaxy s3, android 4.1.2 - and it happened again :)

Thanks,
Doron

2014-02-27 21:24 GMT+02:00 Eddy Verbruggen [email protected]:

Hi, I have an S2 at my office. I'll check it tomorrow.
Can you in the meanwhile confirm this issue on a newer device? No worries
if you can't.

Reply to this email directly or view it on GitHubhttps://github.com//issues/44#issuecomment-36280359
.

[EddyVerbruggen]

OK, damn, I think I found it.. hang on.

2014-02-27 20:34 GMT+01:00 razwasserstein [email protected]:

Hi Eddy,

I checked it on galaxy s3, android 4.1.2 - and it happened again :)

Thanks,
Doron

2014-02-27 21:24 GMT+02:00 Eddy Verbruggen [email protected]:

Hi, I have an S2 at my office. I'll check it tomorrow.
Can you in the meanwhile confirm this issue on a newer device? No worries
if you can't.

Reply to this email directly or view it on GitHub<
#44 (comment)

.

Reply to this email directly or view it on GitHubhttps://github.com//issues/44#issuecomment-36281454
.

[EddyVerbruggen]

Hi Doron, I have confirmed the problem on my S3 testdevice. You were absolutely right and I was able to fix the problem.

I'll submit a new version to Phonegap Build, but the review process is r-e-a-l-l-y slow currently.

[razwasserstein]

Wow Eddy!
I wish phonegap build was as fast as you..
Even half fast would have been good enough!

Thank you very very much!

Doron

2014-02-27 21:50 GMT+02:00 Eddy Verbruggen [email protected]:

Closed #44#44
.

Reply to this email directly or view it on GitHubhttps://github.com//issues/44
.

[EddyVerbruggen]

Haha, lol, I agree ;)

[razwasserstein]

Hi Eddy,
Guess who? yes, it's me again :)
I am sorry again. but build.phonegap.com have finally uploaded your updated
version of the plugin, so we could check it on ios..
Unfortunately when we started the shareViaWhatsapp, in ios the text field
was filled with null again.. but after few trials and errors, we figured
this time it wasn't because of the equal sign, but the hebrew letters :(

Is there a chance you might take a look pleaseeeee?

if you need an example to try - use this:
דורון
(It's my name in hebrew)

Thanks!
Doron

2014-02-27 22:03 GMT+02:00 Eddy Verbruggen [email protected]:

Haha, lol, I agree ;)

—
Reply to this email directly or view it on GitHubhttps://github.com//issues/44#issuecomment-36284892
.

[EddyVerbruggen]

Hi Doron :)

You're now officially my favourite tester! Your issues are spot on and you provide me with a way to reproduce them. I've found the problem, fixed it and submitted version 4.0.2 to Phonegap Build. I hope it will be accepted soon.

Thx,
Eddy

[razwasserstein]

Hi Eddy!
Thank you again!
I will check it as soon as it will be updated in phonegap build.

thanks again!
Doron
בתאריך 2 במרס 2014 22:36, "Eddy Verbruggen" [email protected] כתב:

Hi Doron :)

You're now officially my favourite tester! Your issues are spot on and you
provide me with a way to reproduce them. I've found the problem, fixed it
and submitted version 4.0.2 to Phonegap Build. I hope it will be accepted
soon.

Thx,
Eddy

—
Reply to this email directly or view it on GitHubhttps://github.com//issues/44#issuecomment-36465789
.

[razwasserstein]

Hi Eddy,

How are you?
We got the chance to try your plugin (shareViaSMS) on android 4.4.2 (Nexus
5), and unfortunately it didn't work. We got an error message in the error
callback - "Invalid Action". The shareViaWhatsapp worked just fine..

Can you take another look please?
Thanks,
Doron

2014-03-03 0:30 GMT+02:00 Doron Oded [email protected]:

Hi Eddy!
Thank you again!
I will check it as soon as it will be updated in phonegap build.

thanks again!
Doron
בתאריך 2 במרס 2014 22:36, "Eddy Verbruggen" [email protected]
כתב:

Hi Doron :)

You're now officially my favourite tester! Your issues are spot on and
you provide me with a way to reproduce them. I've found the problem, fixed
it and submitted version 4.0.2 to Phonegap Build. I hope it will be
accepted soon.

Thx,
Eddy

—
Reply to this email directly or view it on GitHubhttps://github.com//issues/44#issuecomment-36465789
.

[EddyVerbruggen]

Oh boy, Google broke this feature on Android 4.4, but rhere is an
alternative which may cover this requirement:
http://stackoverflow.com/questions/19853220/android4-4-can-not-handle-sms-intent-with-vnd-android-dir-mms-sms

I'll have a look!

2014-03-13 19:55 GMT+01:00 razwasserstein [email protected]:

Hi Eddy,

How are you?
We got the chance to try your plugin (shareViaSMS) on android 4.4.2 (Nexus
5), and unfortunately it didn't work. We got an error message in the error
callback - "Invalid Action". The shareViaWhatsapp worked just fine..

Can you take another look please?
Thanks,
Doron

2014-03-03 0:30 GMT+02:00 Doron Oded [email protected]:

Hi Eddy!
Thank you again!
I will check it as soon as it will be updated in phonegap build.

thanks again!
Doron
בתאריך 2 במרס 2014 22:36, "Eddy Verbruggen" [email protected]
כתב:

Hi Doron :)

You're now officially my favourite tester! Your issues are spot on and
you provide me with a way to reproduce them. I've found the problem,
fixed
it and submitted version 4.0.2 to Phonegap Build. I hope it will be
accepted soon.

Thx,
Eddy

—
Reply to this email directly or view it on GitHub<
https://github.com/EddyVerbruggen/SocialSharing-PhoneGap-Plugin/issues/44#issuecomment-36465789>

.

—
Reply to this email directly or view it on GitHubhttps://github.com//issues/44#issuecomment-37572616
.

[razwasserstein]

oh..
hmmm... Eddy we are counting on you!

Good luck!
בתאריך 13 במרס 2014 23:06, "Eddy Verbruggen" [email protected] כתב:

Oh boy, Google broke this feature on Android 4.4, but rhere is an
alternative which may cover this requirement:

http://stackoverflow.com/questions/19853220/android4-4-can-not-handle-sms-intent-with-vnd-android-dir-mms-sms

I'll have a look!

2014-03-13 19:55 GMT+01:00 razwasserstein [email protected]:

Hi Eddy,

How are you?
We got the chance to try your plugin (shareViaSMS) on android 4.4.2
(Nexus
5), and unfortunately it didn't work. We got an error message in the
error
callback - "Invalid Action". The shareViaWhatsapp worked just fine..

Can you take another look please?
Thanks,
Doron

2014-03-03 0:30 GMT+02:00 Doron Oded [email protected]:

Hi Eddy!
Thank you again!
I will check it as soon as it will be updated in phonegap build.

thanks again!
Doron
בתאריך 2 במרס 2014 22:36, "Eddy Verbruggen" [email protected]

כתב:

Hi Doron :)

You're now officially my favourite tester! Your issues are spot on
and
you provide me with a way to reproduce them. I've found the problem,
fixed
it and submitted version 4.0.2 to Phonegap Build. I hope it will be
accepted soon.

Thx,
Eddy

—
Reply to this email directly or view it on GitHub<

https://github.com/EddyVerbruggen/SocialSharing-PhoneGap-Plugin/issues/44#issuecomment-36465789>

.

—
Reply to this email directly or view it on GitHub<
https://github.com/EddyVerbruggen/SocialSharing-PhoneGap-Plugin/issues/44#issuecomment-37572616>

.

—
Reply to this email directly or view it on GitHubhttps://github.com//issues/44#issuecomment-37586836
.

[EddyVerbruggen]

Hi Doron, I don't have a 4.4 device with SMS capabilities. Can I mail you
an apk to test a fix? Plz pm me: eddyverbruggen[at]gmail.com

Thanks!

2014-03-13 22:13 GMT+01:00 razwasserstein [email protected]:

oh..
hmmm... Eddy we are counting on you!

Good luck!
בתאריך 13 במרס 2014 23:06, "Eddy Verbruggen" [email protected]
כתב:

Oh boy, Google broke this feature on Android 4.4, but rhere is an
alternative which may cover this requirement:

http://stackoverflow.com/questions/19853220/android4-4-can-not-handle-sms-intent-with-vnd-android-dir-mms-sms

I'll have a look!

2014-03-13 19:55 GMT+01:00 razwasserstein [email protected]:

Hi Eddy,

How are you?
We got the chance to try your plugin (shareViaSMS) on android 4.4.2
(Nexus
5), and unfortunately it didn't work. We got an error message in the
error
callback - "Invalid Action". The shareViaWhatsapp worked just fine..

Can you take another look please?
Thanks,
Doron

2014-03-03 0:30 GMT+02:00 Doron Oded [email protected]:

Hi Eddy!
Thank you again!
I will check it as soon as it will be updated in phonegap build.

thanks again!
Doron
בתאריך 2 במרס 2014 22:36, "Eddy Verbruggen" <
[email protected]>

כתב:

Hi Doron :)

You're now officially my favourite tester! Your issues are spot on
and
you provide me with a way to reproduce them. I've found the
problem,
fixed
it and submitted version 4.0.2 to Phonegap Build. I hope it will be
accepted soon.

Thx,
Eddy

—
Reply to this email directly or view it on GitHub<

https://github.com/EddyVerbruggen/SocialSharing-PhoneGap-Plugin/issues/44#issuecomment-36465789>

.

—
Reply to this email directly or view it on GitHub<

https://github.com/EddyVerbruggen/SocialSharing-PhoneGap-Plugin/issues/44#issuecomment-37572616>

.

—
Reply to this email directly or view it on GitHub<
https://github.com/EddyVerbruggen/SocialSharing-PhoneGap-Plugin/issues/44#issuecomment-37586836>

.

—
Reply to this email directly or view it on GitHubhttps://github.com//issues/44#issuecomment-37587629
.

[EddyVerbruggen]

Hi Doron,

Thanks for all your help with the SMS issues on KitKat. I have committed a fix and uploaded versio 4.0.4 to build.phonegap.com. They're really slow reviewing lately.

Regards,
Eddy

[razwasserstein]

Hi
thank you very much eddy!
I am sorry for disturbing you all the time.

But you are a very big help for us! Thank you!

Have a great weekend!
Doron

Hi Doron,

Thanks for all your help with the SMS issues on KitKat. I have committed a
fix and uploaded versio 4.0.4 to build.phonegap.com. They're really slow
reviewing lately.

Regards,
Eddy

Reply to this email directly or view it on
GitHubhttps://github.com//issues/44#issuecomment-37640703
.

[razwasserstein]

Hi Eddy,

I have tried to build the project with the new plugin and I get an error:
[image: תמונה מוטבעת 1]

2014-03-14 22:12 GMT+02:00 Doron Oded [email protected]:

Hi
thank you very much eddy!
I am sorry for disturbing you all the time.

But you are a very big help for us! Thank you!

Have a great weekend!
Doron

Hi Doron,

Thanks for all your help with the SMS issues on KitKat. I have committed a
fix and uploaded versio 4.0.4 to build.phonegap.com. They're really slow
reviewing lately.

Regards,
Eddy

—
Reply to this email directly or view it on GitHubhttps://github.com//issues/44#issuecomment-37640703
.

[EddyVerbruggen]

Hi, cant see the error. Can you mail me your project plz?

[razwasserstein]

Hi Eddy,

What folder should I send?
By the way the project's error is: "An error occured while building the
android project. Buildfile .../build.xml"

Thanks,
Doron

2014-03-15 20:16 GMT+02:00 Eddy Verbruggen [email protected]:

Hi, cant see the error. Can you mail me your project plz?

Reply to this email directly or view it on GitHubhttps://github.com//issues/44#issuecomment-37733458
.

[EddyVerbruggen]

As much as possible. The entire project.. if it's too big use wetransfer.

2014-03-16 8:05 GMT+01:00 razwasserstein [email protected]:

Hi Eddy,

What folder should I send?
By the way the project's error is: "An error occured while building the
android project. Buildfile .../build.xml"

Thanks,
Doron

2014-03-15 20:16 GMT+02:00 Eddy Verbruggen [email protected]:

Hi, cant see the error. Can you mail me your project plz?

Reply to this email directly or view it on GitHub<
#44 (comment)

.

Reply to this email directly or view it on GitHubhttps://github.com//issues/44#issuecomment-37750947
.

[EddyVerbruggen]

Hi Doron,

I had to change two things in your project:

• MyActivity.java had a missing import
• SocialSharing.java had a missing import (oops) --> please update this file from the repo, the other files don't need updating.

Thanks!
Eddy

[razwasserstein]

Hi Eddy,
Thank you very much for all your help, and I am very sorry for my slow
understanding..
I tried to remove the plugin and add it again.. the build still didn't
succeed..
Should I change th java files manually?

Thanks,
Doron

2014-03-16 10:11 GMT+02:00 Eddy Verbruggen [email protected]:

Hi Doron,

I had to change two things in your project:

• MyActivity.java had a missing import
• SocialSharing.java had a missing import (oops) --> please update
  this file from the repo, the other files don't need updating.

Thanks!
Eddy

Reply to this email directly or view it on GitHubhttps://github.com//issues/44#issuecomment-37751690
.

[EddyVerbruggen]

Hi Doron,

No worries, you often find actual issues in my code, so I'm the one who
must be thankful.

Yes, please make the changes manually to both files.

Maybe your error is unrelated, so if you can, change the files and send me
the error you see (as much as possible, not just one line of logging).

2014-03-16 9:32 GMT+01:00 razwasserstein [email protected]:

Hi Eddy,
Thank you very much for all your help, and I am very sorry for my slow
understanding..
I tried to remove the plugin and add it again.. the build still didn't
succeed..
Should I change th java files manually?

Thanks,
Doron

2014-03-16 10:11 GMT+02:00 Eddy Verbruggen [email protected]:

Hi Doron,

I had to change two things in your project:

• MyActivity.java had a missing import
• SocialSharing.java had a missing import (oops) --> please update
  this file from the repo, the other files don't need updating.

Thanks!
Eddy

Reply to this email directly or view it on GitHub<
#44 (comment)

.

Reply to this email directly or view it on GitHubhttps://github.com//issues/44#issuecomment-37751970
.

[razwasserstein]

Hi Eddy,

Where can I find the MyActivity.java file? and what import is missing in it?
What import is missing in the SocialSharing.java?

By the way, how come I should do these changes manually? shouldn't they be
automatic when installing the plugin with the CLI?

Thanks,
Doron

2014-03-16 10:43 GMT+02:00 Eddy Verbruggen [email protected]:

Hi Doron,

No worries, you often find actual issues in my code, so I'm the one who
must be thankful.

Yes, please make the changes manually to both files.

Maybe your error is unrelated, so if you can, change the files and send me
the error you see (as much as possible, not just one line of logging).

2014-03-16 9:32 GMT+01:00 razwasserstein [email protected]:

Hi Eddy,
Thank you very much for all your help, and I am very sorry for my slow
understanding..
I tried to remove the plugin and add it again.. the build still didn't
succeed..
Should I change th java files manually?

Thanks,
Doron

2014-03-16 10:11 GMT+02:00 Eddy Verbruggen [email protected]:

Hi Doron,

I had to change two things in your project:

• MyActivity.java had a missing import
• SocialSharing.java had a missing import (oops) --> please update

this file from the repo, the other files don't need updating.

Thanks!
Eddy

Reply to this email directly or view it on GitHub<

#44 (comment)

.

Reply to this email directly or view it on GitHub<
#44 (comment)

.

Reply to this email directly or view it on GitHubhttps://github.com//issues/44#issuecomment-37752129
.

[EddyVerbruggen]

Hi,

Maybe they have updated already, but the build failure is something else.
It may be related to your local environment, so that's hard for me to say.

What Java IDE are you using? You should be able to see the compile errors
in your editor.

On SocialSharing.java you need 'import java.io.*;' on line 21. The
MainActivity.java was missing an import for 'R'. But don't worry about it
if you can't find the file.

2014-03-16 9:49 GMT+01:00 razwasserstein [email protected]:

Hi Eddy,

Where can I find the MyActivity.java file? and what import is missing in
it?
What import is missing in the SocialSharing.java?

By the way, how come I should do these changes manually? shouldn't they be
automatic when installing the plugin with the CLI?

Thanks,
Doron

2014-03-16 10:43 GMT+02:00 Eddy Verbruggen [email protected]:

Hi Doron,

No worries, you often find actual issues in my code, so I'm the one who
must be thankful.

Yes, please make the changes manually to both files.

Maybe your error is unrelated, so if you can, change the files and send
me
the error you see (as much as possible, not just one line of logging).

2014-03-16 9:32 GMT+01:00 razwasserstein [email protected]:

Hi Eddy,
Thank you very much for all your help, and I am very sorry for my slow
understanding..
I tried to remove the plugin and add it again.. the build still didn't
succeed..
Should I change th java files manually?

Thanks,
Doron

2014-03-16 10:11 GMT+02:00 Eddy Verbruggen [email protected]:

Hi Doron,

I had to change two things in your project:

• MyActivity.java had a missing import
• SocialSharing.java had a missing import (oops) --> please update

this file from the repo, the other files don't need updating.

Thanks!
Eddy

Reply to this email directly or view it on GitHub<

#44 (comment)

.

Reply to this email directly or view it on GitHub<

#44 (comment)

.

Reply to this email directly or view it on GitHub<
#44 (comment)

.

Reply to this email directly or view it on GitHubhttps://github.com//issues/44#issuecomment-37752225
.

[razwasserstein]

Hi Eddy,

I have checked the SocialSharing.java, the line (21) exist just as you
wrote it..
And the other file (MainActivity.java) was not found in the project...

Did you succeed building my project?

Thanks,
Doron

2014-03-16 10:53 GMT+02:00 Eddy Verbruggen [email protected]:

Hi,

Maybe they have updated already, but the build failure is something else.
It may be related to your local environment, so that's hard for me to say.

What Java IDE are you using? You should be able to see the compile errors
in your editor.

On SocialSharing.java you need 'import java.io.*;' on line 21. The
MainActivity.java was missing an import for 'R'. But don't worry about it
if you can't find the file.

2014-03-16 9:49 GMT+01:00 razwasserstein [email protected]:

Hi Eddy,

Where can I find the MyActivity.java file? and what import is missing in
it?
What import is missing in the SocialSharing.java?

By the way, how come I should do these changes manually? shouldn't they
be
automatic when installing the plugin with the CLI?

Thanks,
Doron

2014-03-16 10:43 GMT+02:00 Eddy Verbruggen [email protected]:

Hi Doron,

No worries, you often find actual issues in my code, so I'm the one who
must be thankful.

Yes, please make the changes manually to both files.

Maybe your error is unrelated, so if you can, change the files and send
me
the error you see (as much as possible, not just one line of logging).

2014-03-16 9:32 GMT+01:00 razwasserstein [email protected]:

Hi Eddy,
Thank you very much for all your help, and I am very sorry for my
slow
understanding..
I tried to remove the plugin and add it again.. the build still
didn't
succeed..
Should I change th java files manually?

Thanks,
Doron

2014-03-16 10:11 GMT+02:00 Eddy Verbruggen <[email protected]
:

Hi Doron,

I had to change two things in your project:

• MyActivity.java had a missing import
• SocialSharing.java had a missing import (oops) --> please update

this file from the repo, the other files don't need updating.

Thanks!
Eddy

Reply to this email directly or view it on GitHub<

#44 (comment)

.

Reply to this email directly or view it on GitHub<

#44 (comment)

.

Reply to this email directly or view it on GitHub<

#44 (comment)

.

Reply to this email directly or view it on GitHub<
#44 (comment)

.

Reply to this email directly or view it on GitHubhttps://github.com//issues/44#issuecomment-37752283
.

[EddyVerbruggen]

What is your build command?

On 16 mrt. 2014, at 10:07, razwasserstein [email protected] wrote:

Hi Eddy,

I have checked the SocialSharing.java, the line (21) exist just as you
wrote it..
And the other file (MainActivity.java) was not found in the project...

Did you succeed building my project?

Thanks,
Doron

2014-03-16 10:53 GMT+02:00 Eddy Verbruggen [email protected]:

Hi,

Maybe they have updated already, but the build failure is something else.
It may be related to your local environment, so that's hard for me to say.

What Java IDE are you using? You should be able to see the compile errors
in your editor.

On SocialSharing.java you need 'import java.io.*;' on line 21. The
MainActivity.java was missing an import for 'R'. But don't worry about it
if you can't find the file.

2014-03-16 9:49 GMT+01:00 razwasserstein [email protected]:

Hi Eddy,

Where can I find the MyActivity.java file? and what import is missing in
it?
What import is missing in the SocialSharing.java?

By the way, how come I should do these changes manually? shouldn't they
be
automatic when installing the plugin with the CLI?

Thanks,
Doron

2014-03-16 10:43 GMT+02:00 Eddy Verbruggen [email protected]:

Hi Doron,

No worries, you often find actual issues in my code, so I'm the one who
must be thankful.

Yes, please make the changes manually to both files.

Maybe your error is unrelated, so if you can, change the files and send
me
the error you see (as much as possible, not just one line of logging).

2014-03-16 9:32 GMT+01:00 razwasserstein [email protected]:

Hi Eddy,
Thank you very much for all your help, and I am very sorry for my
slow
understanding..
I tried to remove the plugin and add it again.. the build still
didn't
succeed..
Should I change th java files manually?

Thanks,
Doron

2014-03-16 10:11 GMT+02:00 Eddy Verbruggen <[email protected]
:

Hi Doron,

I had to change two things in your project:

• MyActivity.java had a missing import
• SocialSharing.java had a missing import (oops) --> please update

this file from the repo, the other files don't need updating.

Thanks!
Eddy

Reply to this email directly or view it on GitHub<

#44 (comment)

.

Reply to this email directly or view it on GitHub<

#44 (comment)

.

Reply to this email directly or view it on GitHub<

#44 (comment)

.

Reply to this email directly or view it on GitHub<
#44 (comment)

.

Reply to this email directly or view it on GitHubhttps://github.com//issues/44#issuecomment-37752283
.

—
Reply to this email directly or view it on GitHub.

[razwasserstein]

phonegap build android

2014-03-16 11:09 GMT+02:00 Eddy Verbruggen [email protected]:

What is your build command?

On 16 mrt. 2014, at 10:07, razwasserstein [email protected]
wrote:

Hi Eddy,

I have checked the SocialSharing.java, the line (21) exist just as you
wrote it..
And the other file (MainActivity.java) was not found in the project...

Did you succeed building my project?

Thanks,
Doron

2014-03-16 10:53 GMT+02:00 Eddy Verbruggen [email protected]:

Hi,

Maybe they have updated already, but the build failure is something
else.
It may be related to your local environment, so that's hard for me to
say.

What Java IDE are you using? You should be able to see the compile
errors
in your editor.

On SocialSharing.java you need 'import java.io.*;' on line 21. The
MainActivity.java was missing an import for 'R'. But don't worry about
it
if you can't find the file.

2014-03-16 9:49 GMT+01:00 razwasserstein [email protected]:

Hi Eddy,

Where can I find the MyActivity.java file? and what import is
missing in
it?
What import is missing in the SocialSharing.java?

By the way, how come I should do these changes manually? shouldn't
they
be
automatic when installing the plugin with the CLI?

Thanks,
Doron

2014-03-16 10:43 GMT+02:00 Eddy Verbruggen [email protected]:

Hi Doron,

No worries, you often find actual issues in my code, so I'm the
one who
must be thankful.

Yes, please make the changes manually to both files.

Maybe your error is unrelated, so if you can, change the files and
send
me
the error you see (as much as possible, not just one line of
logging).

2014-03-16 9:32 GMT+01:00 razwasserstein [email protected]:

Hi Eddy,
Thank you very much for all your help, and I am very sorry for
my
slow
understanding..
I tried to remove the plugin and add it again.. the build still
didn't
succeed..
Should I change th java files manually?

Thanks,
Doron

2014-03-16 10:11 GMT+02:00 Eddy Verbruggen <
[email protected]
:

Hi Doron,

I had to change two things in your project:

• MyActivity.java had a missing import
• SocialSharing.java had a missing import (oops) --> please
  update

this file from the repo, the other files don't need updating.

Thanks!
Eddy

Reply to this email directly or view it on GitHub<

#44 (comment)

.

Reply to this email directly or view it on GitHub<

#44 (comment)

.

Reply to this email directly or view it on GitHub<

#44 (comment)

.

Reply to this email directly or view it on GitHub<

#44 (comment)

.

Reply to this email directly or view it on GitHub<
https://github.com/EddyVerbruggen/SocialSharing-PhoneGap-Plugin/issues/44#issuecomment-37752283>

.

Reply to this email directly or view it on GitHub.

Reply to this email directly or view it on GitHubhttps://github.com//issues/44#issuecomment-37752514
.

[EddyVerbruggen]

Hi,

I've successfully compile with that command, but I had to change one line
in SocialSharing.java to make it compile. The SDK version of the local
build is not high enough to know about a KitKat property, so try this:

• Open SocialSharing.java
• Replace 'Build.VERSION_CODES.KITKAT' with '19' (without the quotes).

Please send me your full command output if that doesn't work.

Thx,
Eddy

2014-03-16 10:12 GMT+01:00 razwasserstein [email protected]:

phonegap build android

2014-03-16 11:09 GMT+02:00 Eddy Verbruggen [email protected]:

What is your build command?

On 16 mrt. 2014, at 10:07, razwasserstein [email protected]
wrote:

Hi Eddy,

I have checked the SocialSharing.java, the line (21) exist just as you
wrote it..
And the other file (MainActivity.java) was not found in the project...

Did you succeed building my project?

Thanks,
Doron

2014-03-16 10:53 GMT+02:00 Eddy Verbruggen [email protected]:

Hi,

Maybe they have updated already, but the build failure is something
else.
It may be related to your local environment, so that's hard for me to
say.

What Java IDE are you using? You should be able to see the compile
errors
in your editor.

On SocialSharing.java you need 'import java.io.*;' on line 21. The
MainActivity.java was missing an import for 'R'. But don't worry
about
it
if you can't find the file.

2014-03-16 9:49 GMT+01:00 razwasserstein [email protected]:

Hi Eddy,

Where can I find the MyActivity.java file? and what import is
missing in
it?
What import is missing in the SocialSharing.java?

By the way, how come I should do these changes manually? shouldn't
they
be
automatic when installing the plugin with the CLI?

Thanks,
Doron

2014-03-16 10:43 GMT+02:00 Eddy Verbruggen <
[email protected]>:

Hi Doron,

No worries, you often find actual issues in my code, so I'm the
one who
must be thankful.

Yes, please make the changes manually to both files.

Maybe your error is unrelated, so if you can, change the files
and
send
me
the error you see (as much as possible, not just one line of
logging).

2014-03-16 9:32 GMT+01:00 razwasserstein <
[email protected]>:

Hi Eddy,
Thank you very much for all your help, and I am very sorry for
my
slow
understanding..
I tried to remove the plugin and add it again.. the build still
didn't
succeed..
Should I change th java files manually?

Thanks,
Doron

2014-03-16 10:11 GMT+02:00 Eddy Verbruggen <
[email protected]
:

Hi Doron,

I had to change two things in your project:

• MyActivity.java had a missing import
• SocialSharing.java had a missing import (oops) --> please
  update

this file from the repo, the other files don't need updating.

Thanks!
Eddy

Reply to this email directly or view it on GitHub<

#44 (comment)

.

Reply to this email directly or view it on GitHub<

#44 (comment)

.

Reply to this email directly or view it on GitHub<

#44 (comment)

.

Reply to this email directly or view it on GitHub<

#44 (comment)

.

Reply to this email directly or view it on GitHub<

#44 (comment)

.

Reply to this email directly or view it on GitHub.

Reply to this email directly or view it on GitHub<
#44 (comment)

.

Reply to this email directly or view it on GitHubhttps://github.com//issues/44#issuecomment-37752561
.

[razwasserstein]

Hi Eddy,

Thank you very much!
Now it works! I was able to complie.. Now I will ask my friend to check it
on his Nexus to make sure everything is alright.
I feel kinda bad for making you work on this voluntary all the time..

Regarding the change in the java file, are you going to change this line in
your plugin? I am afraid that if I will remove it and add back again (maybe
for future versions) the change will get lost.. and I won't be able to
compile again..

Thanks again!
Doron

2014-03-16 12:16 GMT+02:00 Eddy Verbruggen [email protected]:

Hi,

I've successfully compile with that command, but I had to change one line
in SocialSharing.java to make it compile. The SDK version of the local
build is not high enough to know about a KitKat property, so try this:

• Open SocialSharing.java
• Replace 'Build.VERSION_CODES.KITKAT' with '19' (without the quotes).

Please send me your full command output if that doesn't work.

Thx,
Eddy

2014-03-16 10:12 GMT+01:00 razwasserstein [email protected]:

phonegap build android

2014-03-16 11:09 GMT+02:00 Eddy Verbruggen [email protected]:

What is your build command?

On 16 mrt. 2014, at 10:07, razwasserstein [email protected]
wrote:

Hi Eddy,

I have checked the SocialSharing.java, the line (21) exist just as
you
wrote it..
And the other file (MainActivity.java) was not found in the
project...

Did you succeed building my project?

Thanks,
Doron

2014-03-16 10:53 GMT+02:00 Eddy Verbruggen <[email protected]
:

Hi,

Maybe they have updated already, but the build failure is something
else.
It may be related to your local environment, so that's hard for me
to
say.

What Java IDE are you using? You should be able to see the compile
errors
in your editor.

On SocialSharing.java you need 'import java.io.*;' on line 21. The
MainActivity.java was missing an import for 'R'. But don't worry
about
it
if you can't find the file.

2014-03-16 9:49 GMT+01:00 razwasserstein <[email protected]
:

Hi Eddy,

Where can I find the MyActivity.java file? and what import is
missing in
it?
What import is missing in the SocialSharing.java?

By the way, how come I should do these changes manually?
shouldn't
they
be
automatic when installing the plugin with the CLI?

Thanks,
Doron

2014-03-16 10:43 GMT+02:00 Eddy Verbruggen <
[email protected]>:

Hi Doron,

No worries, you often find actual issues in my code, so I'm the
one who
must be thankful.

Yes, please make the changes manually to both files.

Maybe your error is unrelated, so if you can, change the files
and
send
me
the error you see (as much as possible, not just one line of
logging).

2014-03-16 9:32 GMT+01:00 razwasserstein <
[email protected]>:

Hi Eddy,
Thank you very much for all your help, and I am very sorry
for
my
slow
understanding..
I tried to remove the plugin and add it again.. the build
still
didn't
succeed..
Should I change th java files manually?

Thanks,
Doron

2014-03-16 10:11 GMT+02:00 Eddy Verbruggen <
[email protected]
:

Hi Doron,

I had to change two things in your project:

• MyActivity.java had a missing import
• SocialSharing.java had a missing import (oops) --> please
  update

this file from the repo, the other files don't need
updating.

Thanks!
Eddy

Reply to this email directly or view it on GitHub<

#44 (comment)

.

Reply to this email directly or view it on GitHub<

#44 (comment)

.

Reply to this email directly or view it on GitHub<

#44 (comment)

.

Reply to this email directly or view it on GitHub<

#44 (comment)

.

Reply to this email directly or view it on GitHub<

#44 (comment)

.

Reply to this email directly or view it on GitHub.

Reply to this email directly or view it on GitHub<

#44 (comment)

.

Reply to this email directly or view it on GitHub<
#44 (comment)

.

Reply to this email directly or view it on GitHubhttps://github.com//issues/44#issuecomment-37753485
.

[EddyVerbruggen]

Hi Doron,

I have indeed changed the line in the plugin code, so other 'local
builders' with an older SDK won't have the same trouble.

Best regards,
Eddy

2014-03-16 11:40 GMT+01:00 razwasserstein [email protected]:

Hi Eddy,

Thank you very much!
Now it works! I was able to complie.. Now I will ask my friend to check it
on his Nexus to make sure everything is alright.
I feel kinda bad for making you work on this voluntary all the time..

Regarding the change in the java file, are you going to change this line in
your plugin? I am afraid that if I will remove it and add back again (maybe
for future versions) the change will get lost.. and I won't be able to
compile again..

Thanks again!
Doron

2014-03-16 12:16 GMT+02:00 Eddy Verbruggen [email protected]:

Hi,

I've successfully compile with that command, but I had to change one line
in SocialSharing.java to make it compile. The SDK version of the local
build is not high enough to know about a KitKat property, so try this:

• Open SocialSharing.java
• Replace 'Build.VERSION_CODES.KITKAT' with '19' (without the quotes).

Please send me your full command output if that doesn't work.

Thx,
Eddy

2014-03-16 10:12 GMT+01:00 razwasserstein [email protected]:

phonegap build android

2014-03-16 11:09 GMT+02:00 Eddy Verbruggen [email protected]:

What is your build command?

On 16 mrt. 2014, at 10:07, razwasserstein <
[email protected]>
wrote:

Hi Eddy,

I have checked the SocialSharing.java, the line (21) exist just as
you
wrote it..
And the other file (MainActivity.java) was not found in the
project...

Did you succeed building my project?

Thanks,
Doron

2014-03-16 10:53 GMT+02:00 Eddy Verbruggen <
[email protected]
:

Hi,

Maybe they have updated already, but the build failure is
something
else.
It may be related to your local environment, so that's hard for
me
to
say.

What Java IDE are you using? You should be able to see the
compile
errors
in your editor.

On SocialSharing.java you need 'import java.io.*;' on line 21.
The
MainActivity.java was missing an import for 'R'. But don't worry
about
it
if you can't find the file.

2014-03-16 9:49 GMT+01:00 razwasserstein <
[email protected]
:

Hi Eddy,

Where can I find the MyActivity.java file? and what import is
missing in
it?
What import is missing in the SocialSharing.java?

By the way, how come I should do these changes manually?
shouldn't
they
be
automatic when installing the plugin with the CLI?

Thanks,
Doron

2014-03-16 10:43 GMT+02:00 Eddy Verbruggen <
[email protected]>:

Hi Doron,

No worries, you often find actual issues in my code, so I'm
the
one who
must be thankful.

Yes, please make the changes manually to both files.

Maybe your error is unrelated, so if you can, change the
files
and
send
me
the error you see (as much as possible, not just one line of
logging).

2014-03-16 9:32 GMT+01:00 razwasserstein <
[email protected]>:

Hi Eddy,
Thank you very much for all your help, and I am very sorry
for
my
slow
understanding..
I tried to remove the plugin and add it again.. the build
still
didn't
succeed..
Should I change th java files manually?

Thanks,
Doron

2014-03-16 10:11 GMT+02:00 Eddy Verbruggen <
[email protected]
:

Hi Doron,

I had to change two things in your project:

• MyActivity.java had a missing import
• SocialSharing.java had a missing import (oops) -->
  please
  update

this file from the repo, the other files don't need
updating.

Thanks!
Eddy

Reply to this email directly or view it on GitHub<

#44 (comment)

.

Reply to this email directly or view it on GitHub<

#44 (comment)

.

Reply to this email directly or view it on GitHub<

#44 (comment)

.

Reply to this email directly or view it on GitHub<

#44 (comment)

.

Reply to this email directly or view it on GitHub<

#44 (comment)

.

Reply to this email directly or view it on GitHub.

Reply to this email directly or view it on GitHub<

#44 (comment)

.

Reply to this email directly or view it on GitHub<

#44 (comment)

.

Reply to this email directly or view it on GitHub<
#44 (comment)

.

Reply to this email directly or view it on GitHubhttps://github.com//issues/44#issuecomment-37753855
.

[razwasserstein]

Hi Eddy,

The plugin (shareViaSMS) now works on android 4.4 :)
Thank you very much!

Doron

2014-03-16 12:43 GMT+02:00 Eddy Verbruggen [email protected]:

Hi Doron,

I have indeed changed the line in the plugin code, so other 'local
builders' with an older SDK won't have the same trouble.

Best regards,
Eddy

2014-03-16 11:40 GMT+01:00 razwasserstein [email protected]:

Hi Eddy,

Thank you very much!
Now it works! I was able to complie.. Now I will ask my friend to check
it
on his Nexus to make sure everything is alright.
I feel kinda bad for making you work on this voluntary all the time..

Regarding the change in the java file, are you going to change this line
in
your plugin? I am afraid that if I will remove it and add back again
(maybe
for future versions) the change will get lost.. and I won't be able to
compile again..

Thanks again!
Doron

2014-03-16 12:16 GMT+02:00 Eddy Verbruggen [email protected]:

Hi,

I've successfully compile with that command, but I had to change one
line
in SocialSharing.java to make it compile. The SDK version of the local
build is not high enough to know about a KitKat property, so try this:

• Open SocialSharing.java
• Replace 'Build.VERSION_CODES.KITKAT' with '19' (without the quotes).

Please send me your full command output if that doesn't work.

Thx,
Eddy

2014-03-16 10:12 GMT+01:00 razwasserstein [email protected]:

phonegap build android

2014-03-16 11:09 GMT+02:00 Eddy Verbruggen <[email protected]
:

What is your build command?

On 16 mrt. 2014, at 10:07, razwasserstein <
[email protected]>
wrote:

Hi Eddy,

I have checked the SocialSharing.java, the line (21) exist just
as
you
wrote it..
And the other file (MainActivity.java) was not found in the
project...

Did you succeed building my project?

Thanks,
Doron

2014-03-16 10:53 GMT+02:00 Eddy Verbruggen <
[email protected]
:

Hi,

Maybe they have updated already, but the build failure is
something
else.
It may be related to your local environment, so that's hard for
me
to
say.

What Java IDE are you using? You should be able to see the
compile
errors
in your editor.

On SocialSharing.java you need 'import java.io.*;' on line 21.
The
MainActivity.java was missing an import for 'R'. But don't
worry
about
it
if you can't find the file.

2014-03-16 9:49 GMT+01:00 razwasserstein <
[email protected]
:

Hi Eddy,

Where can I find the MyActivity.java file? and what import is
missing in
it?
What import is missing in the SocialSharing.java?

By the way, how come I should do these changes manually?
shouldn't
they
be
automatic when installing the plugin with the CLI?

Thanks,
Doron

2014-03-16 10:43 GMT+02:00 Eddy Verbruggen <
[email protected]>:

Hi Doron,

No worries, you often find actual issues in my code, so I'm
the
one who
must be thankful.

Yes, please make the changes manually to both files.

Maybe your error is unrelated, so if you can, change the
files
and
send
me
the error you see (as much as possible, not just one line
of
logging).

2014-03-16 9:32 GMT+01:00 razwasserstein <
[email protected]>:

Hi Eddy,
Thank you very much for all your help, and I am very
sorry
for
my
slow
understanding..
I tried to remove the plugin and add it again.. the build
still
didn't
succeed..
Should I change th java files manually?

Thanks,
Doron

2014-03-16 10:11 GMT+02:00 Eddy Verbruggen <
[email protected]
:

Hi Doron,

I had to change two things in your project:

• MyActivity.java had a missing import
• SocialSharing.java had a missing import (oops) -->
  please
  update

this file from the repo, the other files don't need
updating.

Thanks!
Eddy

Reply to this email directly or view it on GitHub<

#44 (comment)

.

Reply to this email directly or view it on GitHub<

#44 (comment)

.

Reply to this email directly or view it on GitHub<

#44 (comment)

.

Reply to this email directly or view it on GitHub<

#44 (comment)

.

Reply to this email directly or view it on GitHub<

#44 (comment)

.

Reply to this email directly or view it on GitHub.

Reply to this email directly or view it on GitHub<

#44 (comment)

.

Reply to this email directly or view it on GitHub<

#44 (comment)

.

Reply to this email directly or view it on GitHub<

#44 (comment)

.

Reply to this email directly or view it on GitHub<
#44 (comment)

.

Reply to this email directly or view it on GitHubhttps://github.com//issues/44#issuecomment-37753891
.