Giter Site home page Giter Site logo

Comments (6)

bittner avatar bittner commented on July 30, 2024

Ah, the "problem" only is that the directory containing the repository is called puppet-software instead of just the module name, software. This is natural when you do a simple clone with Git.

How do other repos deal with this? In the end, it's a sensible choice to prefix a Puppet module's repo name with puppet-.

from puppet-software.

edestecd avatar edestecd commented on July 30, 2024

The default rake task runs all the tests, including puppet-lint:
https://github.com/edestecd/puppet-software/blob/master/Rakefile#L29

I usually just run: rake

that sets up everything. Most modules use rake tasks to run the tests with travis ci

from puppet-software.

bittner avatar bittner commented on July 30, 2024

There are some comments on your repo from a Puppet Labs employee. puppetlabs/pdk#254 (comment)

You may want to check that. (I'm not proficient and fluent in Ruby to be able to judge this properly.)

from puppet-software.

edestecd avatar edestecd commented on July 30, 2024

@bittner OK, I was not aware of pdk. I'll check it out. This module could definitely use some love and updating. I still have yet to switch over to some puppet 4 conventions. It is compatible but puppet 4 throws some warnings. It is my intention to go through it and get it updated to the latest standards in the near future. I was going to compare to one of the puppetlabs modules as an example... I'll def have a look at making it compatable with pdk.

from puppet-software.

bittner avatar bittner commented on July 30, 2024

Don't worry! PDK has been released just recently. It's the new kid on the block.

from puppet-software.

bittner avatar bittner commented on July 30, 2024

This could likely be fixed by PR #15.

from puppet-software.

Related Issues (12)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.