Incompatibility with lib/pq Golang PostgreSQL driver for read-only SQL

[tomnz]

Incompatibility with lib/pq Golang PostgreSQL driver for read-only SQL

[aljazerzen]

I've verified that the go pq library's ping now works.

[Novark]

@aljazerzen Thanks for that clarification - it sounds like the fix is to adjust how edgedb responds to no-op queries in order to match how Postgres does things, and shouldn't require any action by third-party providers.

Fingers crossed for a fix here so that #6437 can be resolved!

[msullivan]

(I think this seems like a server protocol issue?)

[fantix]

Yeah, 'n' seems to be the NoData message we yield.

[fantix]

... which we shouldn't have in the case of an empty SQL query like ;, because Postgres doesn't. I'll push a fix.

[Novark]

@fantix Out of curiosity, would this issue affect other providers that don't use lib/pq, or is this strictly an issue with the way that lib/pq implements its Ping() functionality? In other words, is this something that third party providers should be mindful of, or is it an issue with the way the edgedb driver replies to no-op queries?

[aljazerzen]

@Novark From what I understand, this part is not really clear, because postgres docs don't specify this sufficiently. Because of that, the exact behavior is defined by "what Postgres does".

So it is up to edgedb to do "exactly what Postgres does", so any Postgres client is also compatible with edgedb.