JSON response causes error

[edgurgel]

JSON response causes error

[edgurgel]

Can you share the last line executed on HTTPoison code? Also which version are you using?

[BlakeWilliams]

Sure thing!

I'm using 0.4 and I'm calling HTTPoison.get("http://endpoint.herokuapp.com/long/api/path", headers)

Turns out the request succeeds locally where I don't have much data, but it seems to fail when I hit the remote endpoint which has a bit larger amount. It's nothing ridiculous though.

Sorry for the poor error report, it's late and I didn't know if this would actually get addressed any time soon.

Hackney gave :closed and the response back, I got this from removing the raise on body issues.

[BlakeWilliams]

So the issue might just be that HTTPoison only responds with the body only on {:ok, body} and not {:closed, body} as well?

[edgurgel]

Found the issue:

HTTPoison is calling to_string on this tuple. I think the right thing is to pass the reason as it's.

Adding this test on httpoison_base_test.exs shows the issue:

  test "request failing with a error reason tuple" do
    expect(:hackney, :request, 5, {:error, {:closed, "Something happened"}})

    assert_raise HTTPoison.HTTPError, "...", fn ->
      HTTPoison.post("localhost", "body")
    end

    assert validate :hackney
  end

Speaking of this, I'm also considering (as a breaking change) to not raise errors, just return a HTTPError struct. It would have a better behaviour and perfect for just pattern matching. I'll open an issue as "discussion".

Edited to add the place where we call to_string: https://github.com/edgurgel/httpoison/blob/master/lib/httpoison/base.ex#L93-L94

[BlakeWilliams]

Sounds good, I think that's a much better way to approach the issue and was considering bringing it up.

[edgurgel]

Released a new version with this fix: https://github.com/edgurgel/httpoison/releases/tag/0.4.3 , https://hex.pm/packages/httpoison/0.4.3

0.5.* may not have exceptions anymore.

[BlakeWilliams]

Thanks!