Support for XML Namespaces and some cosmetic changes

[GoogleCodeExporter]

Support for XML Namespaces and some cosmetic changes

[GoogleCodeExporter]

Hi!

I have the following comments. It appears to me that the createElement changes 
should
go into jQuery rather than Flot as Flot is using standard jQuery syntax as far 
as I
know? Is there any reason this won't work? I'd rather have jQuery do what it's 
best
at, abstracting over platform details.

It's a bit hard to evaluate the other changes because they are mixed with the 
DOM stuff.

About the target: it's noted in the documentation that Flot will modify some
properties of it. I thought I had some reason for not inserting a custom-made 
div
inside, but maybe I just didn't think about absolute positioning. It's probably 
silly
not to support absolute out of the box, it's just going to cause confusion.

About the legend alignment: I'd like to hear the problem?

About tabs: you're right. I've hacked on Flot on a non-fixed Emacs, it must have
sneaked in the tabs.

Original comment by olau%[email protected] on 13 Dec 2007 at 6:40

[GoogleCodeExporter]

Hmm, something like "$.createElement"? I think it's fine either way since it's 
just a
shortcut to "document.createElementNS" if exists.

About the legend alignment, I added "vertical-align:middle;" to the cells of the
legend's table, works where supported and if the text wraps in many lines, the
field's box will still be centered.

Anyway, thanks for this awesome plugin.

Original comment by [email protected] on 15 Dec 2007 at 12:09

[GoogleCodeExporter]

Thanks!

I can't reproduce the problem you describe with the legend alignment. If I add 
a long
legend text with a <br>, the box is aligned in the middle of the text. So I 
don't
think it needs to be hardcoded.

About the namespace stuff - I can see where you're coming from. But the typed 
HTML is
much faster, takes up less space and is also easier to read. If it doesn't work 
in a
XUL page, I think that the solution would be to fix up Firefox in some way so 
that it
can support HTML inside XML documents (this would also make other libraries 
work out
of the box).

Maybe Firefox needs support for saying "the following calls are to interpreted 
with
an HTML namespace" or "the default namespace is now HTML"?

Original comment by olau%[email protected] on 6 Mar 2008 at 5:08

[GoogleCodeExporter]

I'm going to close this now since it appears to me that it's not a Flot change 
that
needs to happen.

Original comment by olau%[email protected] on 8 Sep 2008 at 10:28

• Changed state: WontFix

[GoogleCodeExporter]

Original comment by [email protected] on 4 Jun 2012 at 2:41