Giter Site home page Giter Site logo

Comments (7)

edtechre avatar edtechre commented on August 25, 2024 1

Hi @none2003,

I may be able to add support for this by allowing multiple indicator names:
pybroker.indicator(name=['upperband', 'middleband', 'lowerband'], lambda data: talib.BBANDS(data.close))

I will look into the feasibility of this.

from pybroker.

edtechre avatar edtechre commented on August 25, 2024

Hi @none2003,

Yes, this is because indicators only support one output. You will need to create separate indicators for each of the upperband, middleband, and lowerband outputs.

from pybroker.

none2003 avatar none2003 commented on August 25, 2024

Hi @edtechre,

I have used backtesting.py, which also uses a decorator to encapsulate the results returned by the indicator:

self.upperband, self.middleband, self.lowerband = self.I(talib.BBANDS, self.data.Close)

These return values can then be used in the "next" method (similar to the "execute(ctx: ExecContext)" method in pyb):

...
if self.data.Close[-1] > self.upperband[-1]:
    pass
...

This is much easier than defining a method for each return value of the indicator, and I really hope pyb supports such a feature.

Maybe you can take a look at their implementation of this "I" method:

https://github.com/kernc/backtesting.py/blob/master/backtesting/backtesting.py line 78

from pybroker.

none2003 avatar none2003 commented on August 25, 2024

Hi @none2003,

I may be able to add support for this by allowing multiple indicator names: pybroker.indicator(name=['upperband', 'middleband', 'lowerband'], lambda data: talib.BBANDS(data.close))

I will look into the feasibility of this.

Hi @edtechre,

This looks good, have you had time to research on this?

from pybroker.

edtechre avatar edtechre commented on August 25, 2024

Hi @none2003,

I have decided not to make this change as it would not be compatible with how indicator calculations are parallelized across multiple CPUs. My recommendation is to create separate indicators for each output, which is only a minor inconvenience.

from pybroker.

tsunamilx avatar tsunamilx commented on August 25, 2024

Hi @edtechre

So what you suggest is like:

bbup = pybroker.indicator('bbup', lambda data: talib.BBANDS(data.close).upperband)
bbdn = pybroker.indicator('bbdn', lambda data: talib.BBANDS(data.close).lowerband)
bbmd = pybroker.indicator('bbmd', lambda data: talib.BBANDS(data.close).middleband)

Is that right? If so, will it repeat the bbands calculation 3 times?

from pybroker.

edtechre avatar edtechre commented on August 25, 2024

Hi @tsunamilx,

Yes, that is true. But the TA-Lib calculation is very fast, so you should see very little difference in performance.

from pybroker.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.