Comments (4)
I have a fix in progress, but will need to add a testing dependency on something like nock for mocking http responses. If you prefer another testing approach, let me know.
from node-tvdb.
Hey Tom!
Thanks for looking into this! Completely missed that node-fetch
doesn't handle 4xx
and 5xx
HTTP errors. Agreed that node-tvdb
should be handling these properly.
Your approach to check for valid response, then rejecting with an error if invalid sounds good. Using nock is fine (I've been meaning to add something like this to the library's tests for a while now anyway).
Let me know if you need any help with getting a fix finished up. Would be great to have that merged in ASAP
from node-tvdb.
Hey @tgvarik! Any progress on the PR? Keen to get this bug fixed ASAP. Will fix myself if you don't have the time after all.
Cheers :)
from node-tvdb.
Incoming momentarily...
from node-tvdb.
Related Issues (20)
- Version 10 of node.js has been released
- An in-range update of nock is breaking the build 🚨 HOT 1
- An in-range update of nock is breaking the build 🚨 HOT 2
- An in-range update of mocha is breaking the build 🚨 HOT 5
- An in-range update of jsdoc is breaking the build 🚨 HOT 4
- An in-range update of sinon is breaking the build 🚨 HOT 2
- An in-range update of mocha is breaking the build 🚨 HOT 1
- An in-range update of eslint-plugin-mocha is breaking the build 🚨 HOT 2
- An in-range update of eslint is breaking the build 🚨 HOT 4
- An in-range update of sinon-chai is breaking the build 🚨 HOT 1
- An in-range update of nock is breaking the build 🚨 HOT 5
- Release with index.d.ts HOT 2
- Node engine compatibility HOT 3
- Error: Text data outside root node HOT 3
- `getSeriesByName` fails if the name needs to be URL-encoded HOT 1
- Website issues HOT 2
- Typo in documentation HOT 1
- An in-range update of mocha is breaking the build 🚨 HOT 1
- Access-Control-Allow-Origin HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from node-tvdb.