Comments (7)
Good call! I agree with you, I think we should just drop the SIG
prefix if it works across shells. I'd welcome a PR if you have the bandwidth to do so
from primer-spec.
Just made one!
On a similar note, .githooks/pre-commit
doesn't work with dash, as set -o pipefail
is an illegal option. When I tried switching to bash, the script exited 1 when it reached the line MINOR_VERSION=$(cat $PROJECT_ROOT/VERSION | grep -o "\d\.\d")
.
from primer-spec.
It's because dirname /home/noah/primer-spec
outputs /home/noah
, which doesn't have a VERSION
file.
from primer-spec.
On a similar note,
.githooks/pre-commit
doesn't work with dash, asset -o pipefail
is an illegal option.
I think we can safely remove the pipefail
option. Do you see other errors in dash after removing that?
It's because
dirname /home/noah/primer-spec
outputs/home/noah
, which doesn't have aVERSION
file.
Hmm… the pre-commit hook is supposed to find its own directory and then find the project root from there.
primer-spec/.githooks/pre-commit
Lines 7 to 11 in 83b3d4b
Could you try adding echo
statements to check the value of the variables and working directories? I’m currently suspecting that dirname $0
isn’t working as I expected, but I don’t know for sure…
(I’ve only ever tested the builds and scripts on bash
on my Mac
from primer-spec.
Could you try adding echo statements to check the value of the variables and working directories?
Good call! Sorry, I was lazy last night and misinterpreted the error: dirname
is working fine. The real issue is that my version of grep doesn't recognize \d
, since it's not part of basic regular expressions. Switching to grep -o "[[:digit:]]\.[[:digit:]]"
or grep -o "[0-9]\.[0-9]"
might make the script more cross-platform.
from primer-spec.
I think we can safely remove the pipefail option. Do you see other errors in dash after removing that?
Apparently dash doesn't have a pushd
command.
from primer-spec.
This will be fixed when #195 is merged.
from primer-spec.
Related Issues (20)
- Bump header level styles in sidebar if needed HOT 1
- Primer Spec v2: Require deploy via GitHub Actions? HOT 1
- Task Lists: Use 'pointer' cursor on hover
- Multi color highlighting HOT 5
- Spooky icons even when Spooky theme not chosen HOT 2
- Data-highlight inside callout HOT 2
- Sidebar links broken in preview HOT 5
- Dark mode code blocks flash when settings is closed HOT 1
- Markdown tables are not rendered HOT 2
- Copy button in enhanced codeblock omits whitespace HOT 3
- Enhanced code block copy-paste trailing newline
- [PR Previews] PDFs do not generate with correct styles the first time.
- [Code blocks] Overflow gets clipped in print previews
- [Enhanced code blocks] No-line-numbers variant doesn't occupy full width
- [Enhanced code blocks] Code block in EECS 280 P1 doesn't highlight lines HOT 1
- [Enhanced Code Blocks] Line-by-line copying excludes empty lines
- Local render Liquid Exception HOT 6
- Copying an enhanced codeblock duplicates newlines HOT 1
- Sidebar has wrong URLs in PR previews HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from primer-spec.