Giter Site home page Giter Site logo

Comments (9)

eerohele avatar eerohele commented on August 21, 2024

cc62d62 should fix the issue. I'll take a look at it with fresh eyes tomorrow and deploy a new version if it looks OK.

@jelovirt: If you have the time, could you give
cc62d62#diff-61637f024646c6410b55b1867e6a2b50R22 a quick once-over and see whether the logic looks OK to you?

from dita-ot-gradle.

infotexture avatar infotexture commented on August 21, 2024

👍 Tested 0.4.2 on dita-ot/docs@6c3e7fca with Gradle 3.5 and 4.2.1, seems to work fine.

Markdown topics are now treated as DITA, and built to HTML as expected, so the changes in cc62d62 are effective, and the new libraries from the external plug-ins are used.

from dita-ot-gradle.

infotexture avatar infotexture commented on August 21, 2024

Discovered a side-effect of the changes in cc62d62:

After updating the plug-in version in dita-ot/docs@6c3e7fca, when I ran gradle wrapper to upgrade to the latest Gradle version,

FAILURE: Build failed with an exception.

Can't find DITA-OT plugin XML file.
Are you sure you're using a valid DITA-OT directory?

Not a show-stopper, as I can still upgrade the wrapper from a prior commit before the new plug-in version landed, but certainly unexpected.

from dita-ot-gradle.

eerohele avatar eerohele commented on August 21, 2024

Agh. Thanks for reporting the issue — I'll look into it.

from dita-ot-gradle.

eerohele avatar eerohele commented on August 21, 2024

I can't seem to reproduce the issue.

Which Gradle version do you have installed? As in, if you do gradle --version, what does it return?

Also, are you running gradle wrapper in the root directory of the DITA-OT docs repo?

from dita-ot-gradle.

infotexture avatar infotexture commented on August 21, 2024
~ D/W/D/docs > $ gradle --version

------------------------------------------------------------
Gradle 4.2.1
------------------------------------------------------------

Build time:   2017-10-02 15:36:21 UTC
Revision:     a88ebd6be7840c2e59ae4782eb0f27fbe3405ddf

Groovy:       2.4.12
Ant:          Apache Ant(TM) version 1.9.6 compiled on June 29 2015
JVM:          1.8.0_144 (Oracle Corporation 25.144-b01)
OS:           Mac OS X 10.12.6 x86_64

from dita-ot-gradle.

infotexture avatar infotexture commented on August 21, 2024

Also, are you running gradle wrapper in the root directory of the DITA-OT docs repo?

Yes, however, my docs clone is alongside the dita-ot directory:

.
├── dita-ot
├── docs

from dita-ot-gradle.

infotexture avatar infotexture commented on August 21, 2024

If I explicitly pass gradle the dita.home location, it works:

gradle wrapper -Ddita.home=../dita-ot/src/main 

from dita-ot-gradle.

eerohele avatar eerohele commented on August 21, 2024

All right, so that exception was caused by a peculiarity in the previous version of the DITA-OT docs build.gradle file.

I think this issue is resolved. The remaining issue (that I know of) is that the plugin doesn't always include the .gradle directory in the up-to-date check even though it should. I'll create a new issue for that one.

from dita-ot-gradle.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.